Skip to content

Fix audit report compliance detail fetch #2262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sk-keeper merged 1 commit into from
Aug 5, 2026
Merged

Fix audit report compliance detail fetch #2262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion keepercommander/commands/aram.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1212,7 +1212,8 @@ def __init__(self):

def get_sox_data(self, params):
if not self.sox_data and is_compliance_reporting_enabled(params):
self.sox_data = get_compliance_data(params, 0, 0,False, min_updated=0, no_cache=False)
min_updated = int(datetime.datetime.now().timestamp()) if self.allow_sox_data_fetch else 0
self.sox_data = get_compliance_data(params, 0, 0, False, min_updated=min_updated, no_cache=False)
return self.sox_data

def get_value(self, params, field, event):
Expand Down
21 changes: 21 additions & 0 deletions unit-tests/test_command_enterprise.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,27 @@ def test_audit_audit_report_parse_int_filter(self):
arr.sort()
self.assertListEqual(arr, [0, 1, 2, 3, 4, 5, 6, 7])

def test_audit_report_sox_fetch_uses_freshness_when_record_details_allowed(self):
params = mock.Mock()
cmd = aram.AuditReportCommand()
cmd.allow_sox_data_fetch = True
sox_data = mock.Mock()
before = int(datetime.now().timestamp())
with mock.patch('keepercommander.commands.aram.is_compliance_reporting_enabled', return_value=True), \
mock.patch('keepercommander.commands.aram.get_compliance_data', return_value=sox_data) as mock_get:
self.assertIs(cmd.get_sox_data(params), sox_data)
min_updated = mock_get.call_args.kwargs.get('min_updated')
self.assertGreaterEqual(min_updated, before)

def test_audit_report_sox_fetch_uses_cache_only_by_default(self):
params = mock.Mock()
cmd = aram.AuditReportCommand()
sox_data = mock.Mock()
with mock.patch('keepercommander.commands.aram.is_compliance_reporting_enabled', return_value=True), \
mock.patch('keepercommander.commands.aram.get_compliance_data', return_value=sox_data) as mock_get:
self.assertIs(cmd.get_sox_data(params), sox_data)
self.assertEqual(mock_get.call_args.kwargs.get('min_updated'), 0)

def test_enterprise_push_command(self):
params = get_connected_params()
api.query_enterprise(params)
Expand Down