VM-1452: replace pickle cache serialization with JSON - #1066
Merged
Conversation
stas-schaller
changed the base branch from
master
to
release/integration/ansible/v1.5.0
July 27, 2026 18:09
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
Remove insecure pickle.loads from the Ansible record cache path (CWE-502) and round-trip Record state via Fernet-encrypted JSON. Co-authored-by: Cursor <cursoragent@cursor.com>
Ignore unusable pickle/invalid record caches without deserializing them, warn, and fetch from the vault so plays continue until keeper_cache_records rebuilds JSON. Co-authored-by: Cursor <cursoragent@cursor.com>
Newer ansible-core can recurse in AnsibleError.__str__; assert on exception args instead so CI stays green. Co-authored-by: Cursor <cursoragent@cursor.com>
stas-schaller
force-pushed
the
VM-1452-insecure-deserialization-via-pickle-in-ansible-integration
branch
from
July 27, 2026 18:34
3f58133 to
e371c6c
Compare
stas-schaller
merged commit Jul 27, 2026
d461226
into
release/integration/ansible/v1.5.0
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VM-1452: replace pickle cache serialization with JSON
Summary: