Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DeductionTimeCalculator.php #9

Closed
wants to merge 1 commit into from

Conversation

boekhorstb1
Copy link

@boekhorstb1 boekhorstb1 commented Oct 19, 2023

I tried to make it compatible with the interface, because I got this error:

#message: "Compile Error: Declaration of App\Timesheet\Calculator\BillableCalculator::calculate(App\Entity\Timesheet $record) must be compatible with App\Timesheet\CalculatorInterface::calculate(App\Entity\Timesheet $record, array $changeset)"
  #code: 0
  #file: "./src/Timesheet/Calculator/BillableCalculator.php"
  #line: 20
  -error: array:4 [
    "type" => 64
    "message" => "Declaration of App\Timesheet\Calculator\BillableCalculator::calculate(App\Entity\Timesheet $record) must be compatible with App\Timesheet\CalculatorInterface::calculate(App\Entity\Timesheet $record, array $changeset)"
    "file" => "/opt/kimai/src/Timesheet/Calculator/BillableCalculator.php"
    "line" => 20

followed installation setup from here:
https://www.kimai.org/de/store/keleo-deduction-time-bundle.html

make it compatible with interface
@kevinpapst
Copy link
Member

Update your Kimai version or stick to the compatibility table

@kevinpapst kevinpapst closed this Oct 19, 2023
@kevinpapst
Copy link
Member

Which means: thank you, but your PR makes no sense.
Seems you are still using Kimai v 1.x - which is not compatible with latest main.

@boekhorstb1
Copy link
Author

boekhorstb1 commented Oct 19, 2023

Allright, I might have been confused by the instruction from here then @kevinpapst . It says this without mentioning the fact that one has to download a specific release from github:

<p dir="auto">This plugin is compatible with the following Kimai releases:</p>


Bundle version | Minimum Kimai version
-- | --
2.0 - 2.0.1 | 2.0.0
1.0 | 1.27.0


<p dir="auto"></p>

my version is 1.30.1 stable (Ayumi) currently., so I will give the release of 1.27 a try then, thanks

Im in the process of updating :) takes bit of time lets say

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants