Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ecommerce common standalone library #1

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Ecommerce common standalone library #1

merged 4 commits into from
Apr 30, 2024

Conversation

martinfbluesoftcz
Copy link
Collaborator

Motivation

Which issue does this fix? Fixes #issue number

If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@martinfbluesoftcz martinfbluesoftcz self-assigned this Apr 23, 2024
michalJakubis
michalJakubis reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@michalJakubis michalJakubis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Also please update documentation. (Readme, contribution guide, etc.)

...Kentico.Xperience.Ecommerce.Common/ContentItemSynchronization/Interfaces/IContentItemBase.cs Outdated Show resolved Hide resolved
...tico.Xperience.Ecommerce.Common/ContentItemSynchronization/ContentItemSynchronizationBase.cs Outdated Show resolved Hide resolved
src/Kentico.Xperience.Ecommerce.Common/ContentItemSynchronization/Interfaces/IItemIdentifier.cs Outdated Show resolved Hide resolved
...ico.Xperience.Ecommerce.Common/ContentItemSynchronization/Interfaces/ISynchronizationItem.cs Outdated Show resolved Hide resolved
@michalJakubis
Copy link
Contributor

michalJakubis commented Apr 24, 2024 •
edited
Loading

Please do not forget to update all occurrences of the "RepoTemplate" placeholder. (e.g.

xperience-by-kentico-ecommerce-common/.vscode/launch.json

Line 12 in d2a1a9a

"program": "${workspaceFolder}/src/Kentico.Xperience.RepoTemplate.Sample/bin/Debug/net6.0/DancingGoat.dll",
)

@martinfbluesoftcz martinfbluesoftcz merged commit 6f8660f into main Apr 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalJakubis michalJakubis michalJakubis approved these changes

Assignees

@martinfbluesoftcz martinfbluesoftcz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinfbluesoftcz @michalJakubis