[Refactor] 코드 리뷰 - 기본 Executor 전략으로 변경#296
Closed
kimminkyeu wants to merge 1 commit intoKernel360:developfrom
kimminkyeu:feat/refactor
Closed
[Refactor] 코드 리뷰 - 기본 Executor 전략으로 변경#296kimminkyeu wants to merge 1 commit intoKernel360:developfrom kimminkyeu:feat/refactor
kimminkyeu wants to merge 1 commit intoKernel360:developfrom
kimminkyeu:feat/refactor
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
코드 리뷰 #292 참고
싱글쓰레드 방식을 사용하는 이유가 확실하지 않고, 이로 인해 코드의 복잡성이 증가하였습니다.
따라서 꼭 SingleThreadedPool를 사용해야 하는 이유가 없다면, 자바에서 기본으로 제공하는 Executor를 사용하는 방식으로 변경합니다.