Skip to content

fix: use visibility hidden for global filter #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alessandrojcm merged 1 commit into from
May 27, 2025
Merged

fix: use visibility hidden for global filter #522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions packages/mantine-react-table/src/components/inputs/MRT_GlobalFilterTextInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,20 +100,22 @@ export const MRT_GlobalFilterTextInput = <TData extends MRT_RowData>({
onChange={(event) => setSearchValue(event.target.value)}
placeholder={localization.search}
rightSection={
searchValue ? (
<ActionIcon
aria-label={localization.clearSearch}
color="gray"
disabled={!searchValue?.length}
onClick={handleClear}
size="sm"
variant="transparent"
>
<Tooltip label={localization.clearSearch} withinPortal>
<IconX />
</Tooltip>
</ActionIcon>
) : null
<ActionIcon
aria-label={localization.clearSearch}
color="gray"
disabled={!searchValue?.length}
hidden={!searchValue}
onClick={handleClear}
size="sm"
style={{
visibility: !searchValue ? 'hidden' : undefined,
}}
variant="transparent"
>
<Tooltip label={localization.clearSearch} withinPortal>
<IconX />
</Tooltip>
</ActionIcon>
}
value={searchValue ?? ''}
variant="filled"
Expand Down