Add health check property to Issuer / ClusterIssuer specification #55
Conversation
…suance flow. Signed-off-by: Matthew H. Irby <[email protected]>
Signed-off-by: Matthew H. Irby <[email protected]>
Signed-off-by: Matthew H. Irby <[email protected]>
Signed-off-by: Matthew H. Irby <[email protected]>
Signed-off-by: Matthew H. Irby <[email protected]>
Signed-off-by: Matthew H. Irby <[email protected]>
Signed-off-by: Matthew H. Irby <[email protected]>
…onds Signed-off-by: Matthew H. Irby <[email protected]>
irby
changed the title
Signed-off-by: Matthew H. Irby <[email protected]>
…ers, if not specified.
Ability to specify the default issuer timeout across all issuers
There was a problem hiding this comment.
Pull Request Overview
This PR adds a configurable health check property to Issuer and ClusterIssuer specifications, enabling users to customize the health check interval and disable health checks if needed. The default behavior maintains backward compatibility with a 60-second health check interval.
- Adds
HealthCheckConfigstruct to the API withenabledandintervalfields - Updates controller to read and validate health check configuration with a minimum interval of 30 seconds
- Adds comprehensive test coverage for various health check scenarios
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| api/v1alpha1/issuer_types.go | Adds HealthCheckConfig struct to IssuerSpec |
| internal/controller/issuer_controller.go | Implements getHealthCheckInterval function with validation logic |
| internal/controller/issuer_controller_test.go | Adds test cases for custom intervals, disabled checks, and validation |
| config/crd/bases/*.yaml | Updates CRD schemas with healthcheck property |
| deploy/charts//templates/crds/.yaml | Updates Helm chart CRDs with healthcheck property |
| cmd/main.go | Adds --default-health-check-interval flag with validation |
| README.md, docsource/content.md | Documents the new healthcheck configuration options |
| e2e/* | Updates e2e tests to use Certificate resources instead of CertificateRequest |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
config/crd/bases/command-issuer.keyfactor.com_clusterissuers.yaml
Outdated
Show resolved
Hide resolved
deploy/charts/command-cert-manager-issuer/templates/crds/issuers.yaml
Outdated
Show resolved
Hide resolved
deploy/charts/command-cert-manager-issuer/templates/crds/clusterissuers.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Matthew H. Irby <[email protected]>
Signed-off-by: Matthew H. Irby <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Matthew H. Irby <[email protected]>
Signed-off-by: Matthew H. Irby <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Matthew H. Irby <[email protected]>
spbsoluble
deleted the
feat/AB#78226/issuer-healthcheck-configuration
branch
No description provided.