-
Notifications
You must be signed in to change notification settings - Fork 4
Document Google Ambient Credentials, Add Timeout for Azure Access Token Generation, Add Env Variable Support #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-2.4
Are you sure you want to change the base?
Conversation
Signed-off-by: Matthew H. Irby <[email protected]>
Signed-off-by: Matthew H. Irby <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds documentation for configuring Google GKE ambient credentials and implements a timeout mechanism for Azure access token generation. The timeout prevents the Azure credential generation process from hanging indefinitely, improving reliability when Azure services are slow or unresponsive.
Key Changes:
- Added comprehensive documentation for configuring GKE workload identity with Keyfactor Command
- Implemented a 10-second timeout for Azure access token retrieval operations
- Added references to the new Google ambient credentials documentation in both the main README and documentation source
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| internal/command/client.go | Added 10-second timeout context for Azure access token generation |
| docsource/content.md | Added link to new Google GKE workload identity documentation |
| docs/ambient-providers/google.md | New comprehensive guide for configuring GKE ambient credentials with Keyfactor Command |
| README.md | Added link to new Google GKE workload identity documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Matthew H. Irby <[email protected]>
Add environmental variables to chart for use with proxies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.