Skip to content

Conversation

@irby
Copy link
Contributor

@irby irby commented Nov 6, 2025

  • Documents how to configure ambient credentials in Google GKE to use with the command-cert-manager-issuer, including what security claims are required for Keyfactor Command auth.
  • Add a 10 second timeout to generating Azure access token
  • Adds env variable specification support, to allow custom environment variables such as the ability to specify HTTP proxies.

@irby irby marked this pull request as draft November 6, 2025 18:39
@irby irby marked this pull request as ready for review December 2, 2025 21:25
Copilot AI review requested due to automatic review settings December 2, 2025 21:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds documentation for configuring Google GKE ambient credentials and implements a timeout mechanism for Azure access token generation. The timeout prevents the Azure credential generation process from hanging indefinitely, improving reliability when Azure services are slow or unresponsive.

Key Changes:

  • Added comprehensive documentation for configuring GKE workload identity with Keyfactor Command
  • Implemented a 10-second timeout for Azure access token retrieval operations
  • Added references to the new Google ambient credentials documentation in both the main README and documentation source

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
internal/command/client.go Added 10-second timeout context for Azure access token generation
docsource/content.md Added link to new Google GKE workload identity documentation
docs/ambient-providers/google.md New comprehensive guide for configuring GKE ambient credentials with Keyfactor Command
README.md Added link to new Google GKE workload identity documentation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

irby and others added 2 commits December 15, 2025 10:22
Add environmental variables to chart for use with proxies
Copilot AI review requested due to automatic review settings December 15, 2025 15:25
@irby irby changed the title Document Google Ambient Credentials + Add Timeout for Azure Access Token Generation Document Google Ambient Credentials, Add Timeout for Azure Access Token Generation, Add Env Variable Support Dec 15, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants