Ab#70161 #12
Ab#70161 #12
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the F5 Big IQ Orchestrator Extension to version 2.0, which modifies the On Device Key Generation (ODKG/Reenrollment) functionality to leverage Keyfactor Command/Universal Orchestrator 25.3 features for SANs, Alias, and Overwrite handling.
Key Changes:
- Removed EntryParameters from integration manifest (SANs, Alias, Overwrite now handled by Command 25.3+)
- Updated Reenrollment.cs to use config properties instead of JobProperties for Alias, Overwrite, and SANs
- Updated package dependencies and documentation to reflect v2.0 and minimum version requirements
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| integration-manifest.json | Removed EntryParameters array (SANs, Alias, Overwrite) for ODKG operations |
| docsource/content.md | Updated terminology from "Reenrollment" to "ODKG" and added v2.0 version requirement note |
| README.md | Updated terminology, added v2.0 version requirement note, restructured documentation sections, and fixed typos |
| F5BigIQ/Reenrollment.cs | Refactored to use config properties instead of JobProperties, added SAN formatting logic, and introduced unused imports |
| F5BigIQ/F5BigIQ.csproj | Updated package versions and added duplicate reference entry |
| CHANGELOG.md | Added v2.0.0 release notes |
| .github/workflows/keyfactor-bootstrap-workflow.yml | Updated workflow to use v4 and added doctool-related configuration |
Comments suppressed due to low confidence (1)
F5BigIQ/Reenrollment.cs:84
- String concatenation in loop: use 'StringBuilder'.
sans += (key + ":" + value + ",");
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <Reference Include="Keyfactor.Orchestrators.IOrchestratorJobExtensions"> | ||
| <HintPath>External References\Keyfactor.Orchestrators.IOrchestratorJobExtensions.dll</HintPath> | ||
| </Reference> | ||
|
|
There was a problem hiding this comment.
The package reference Keyfactor.Orchestrators.IOrchestratorJobExtensions is duplicated - it appears both as a PackageReference on line 12 and as a Reference with HintPath on lines 17-19. Remove the duplicate Reference to avoid potential conflicts.
| <Reference Include="Keyfactor.Orchestrators.IOrchestratorJobExtensions"> | |
| <HintPath>External References\Keyfactor.Orchestrators.IOrchestratorJobExtensions.dll</HintPath> | |
| </Reference> |
| sans += (key + ":" + value + ","); | ||
| } |
There was a problem hiding this comment.
String concatenation in a loop is inefficient. Consider using StringBuilder for better performance when building the sans string, especially since SANs can potentially have multiple entries.
| The F5 BigIQ Universal Orchestrator extension is supported by Keyfactor for Keyfactor customers. If you have a support issue, please open a support ticket with your Keyfactor representative. If you have a support issue, please open a support ticket via the Keyfactor Support Portal at https://support.keyfactor.com. | ||
| > To report a problem or suggest a new feature, use the **[Issues](../../issues)** tab. If you want to contribute actual bug fixes or proposed enhancements, use the **[Pull requests](../../pulls)** tab. | ||
| The F5 BigIQ Universal Orchestrator extension is supported by Keyfactor. If you require support for any issues or have feature request, please open a support ticket by either contacting your Keyfactor representative or via the Keyfactor Support Portal at https://support.keyfactor.com. |
There was a problem hiding this comment.
Grammar issue: "have feature request" should be "have a feature request" or "have feature requests".
| The F5 BigIQ Universal Orchestrator extension is supported by Keyfactor. If you require support for any issues or have feature request, please open a support ticket by either contacting your Keyfactor representative or via the Keyfactor Support Portal at https://support.keyfactor.com. | |
| The F5 BigIQ Universal Orchestrator extension is supported by Keyfactor. If you require support for any issues or have feature requests, please open a support ticket by either contacting your Keyfactor representative or via the Keyfactor Support Portal at https://support.keyfactor.com. |
|
|
||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Net.NetworkInformation; |
There was a problem hiding this comment.
Unused imports should be removed. The imports System.Net.NetworkInformation, Microsoft.Win32.SafeHandles, and static Org.BouncyCastle.Math.EC.ECCurve are not used anywhere in this file.
| using Microsoft.Win32.SafeHandles; | ||
| using static Org.BouncyCastle.Math.EC.ECCurve; | ||
|
|
There was a problem hiding this comment.
Unused imports should be removed. The imports Microsoft.Win32.SafeHandles and static Org.BouncyCastle.Math.EC.ECCurve are not used anywhere in this file.
| using Microsoft.Win32.SafeHandles; | |
| using static Org.BouncyCastle.Math.EC.ECCurve; |
No description provided.