fix: replace code_analysis_deliverable with pre_recon_deliverable (#258)#259
Open
TheNotoBarth wants to merge 1 commit intoKeygraphHQ:mainfrom
Open
fix: replace code_analysis_deliverable with pre_recon_deliverable (#258)#259TheNotoBarth wants to merge 1 commit intoKeygraphHQ:mainfrom
TheNotoBarth wants to merge 1 commit intoKeygraphHQ:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a workflow-breaking filename mismatch by renaming the pre-recon phase deliverable output to the filename expected by downstream agents/consumers (Issue #258).
Changes:
- Updated the CODE_ANALYSIS deliverable filename mapping to
pre_recon_deliverable.md. - Updated the pre-recon agent’s configured deliverable filename and validator to use
pre_recon_deliverable.md. - Updated the pre-recon prompt instructions to write/save
deliverables/pre_recon_deliverable.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/worker/src/types/deliverables.ts | Remaps DeliverableType.CODE_ANALYSIS to the downstream-expected pre_recon_deliverable.md. |
| apps/worker/src/session-manager.ts | Aligns pre-recon agent configuration + validator checks with the new deliverable filename. |
| apps/worker/prompts/pre-recon-code.txt | Updates prompt instructions so the agent writes/saves the correct deliverable filename. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
180
to
183
| // Pre-reconnaissance agent - validates the code analysis deliverable created by the agent | ||
| 'pre-recon': async (sourceDir: string): Promise<boolean> => { | ||
| const codeAnalysisFile = path.join(sourceDir, 'deliverables', 'code_analysis_deliverable.md'); | ||
| const codeAnalysisFile = path.join(sourceDir, 'deliverables', 'pre_recon_deliverable.md'); | ||
| return await fs.pathExists(codeAnalysisFile); |
There was a problem hiding this comment.
The pre-recon validator now checks for pre_recon_deliverable.md, but the local variable name (codeAnalysisFile) and the preceding comment still refer to “code analysis deliverable”. Renaming the variable/comment to match the new deliverable filename would avoid confusion when debugging validation failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I modified the output file name of pre-recon-agent to solve this issue（#258）