Skip to content

Conversation

@harsh-sikhwal
Copy link
Collaborator

This PR addresses a simple single tier rack fabric builder - takes the device as an input and the device count and generates a single tier rack fabric connected to the n number of devices.

@harsh-sikhwal harsh-sikhwal self-assigned this Oct 28, 2025
Copy link
Collaborator

@ajbalogh ajbalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rack fabric naming convention is too generic - its limited to a single tier rack fabric and the naming convention should reflect that. The test should also reflect that it is only testing a single tier rack fabric

@ajbalogh ajbalogh self-requested a review October 28, 2025 13:59
ajbalogh
ajbalogh previously approved these changes Oct 28, 2025
Copy link
Collaborator

@ajbalogh ajbalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ajbalogh ajbalogh self-requested a review October 28, 2025 15:22
@ajbalogh ajbalogh merged commit 46d84af into main Oct 28, 2025
@ajbalogh ajbalogh deleted the feature-single-tor-blueprint branch October 28, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants