Improved the analytics and log events.#350
Merged
Merged
Conversation
Gauravjeetsingh
requested changes
Dec 9, 2025
| onReady={() => { | ||
| routeNameRef.current = navigationRef.current.getCurrentRoute().name; | ||
| }} | ||
| onStateChange={async (state) => { |
Collaborator
There was a problem hiding this comment.
Minor thing, this can be modularized, create a separate function for this logic, and then call it here.
| routeNameRef.current = navigationRef.current.getCurrentRoute().name; | ||
| }} | ||
| onStateChange={async (state) => { | ||
| handlingStateChange(state); |
Collaborator
There was a problem hiding this comment.
The handlingStateChange function is async but called without await in the onStateChange handler. Any specific reason for this?
Collaborator
Author
There was a problem hiding this comment.
I was uncertain about using await here because I want the navigation to continue immediately without being blocked.
| const summarizeState = (state) => { | ||
| const summary = {}; | ||
| let count = 0; | ||
| Object.entries(state || {}).some(([key, value]) => { |
Collaborator
There was a problem hiding this comment.
It works, but is slightly weird use case of some(). What if we keep it simple with a for loop with a break statement if count is greater than/equal to MAX_STATE_KEYS
for (const [key, value] of Object.entries(state || {})) {
if (count >= MAX_STATE_KEYS) break;
if (value === undefined) continue;
if (
typeof value === "string" ||
typeof value === "number" ||
typeof value === "boolean"
) {
const crashlyticsKey = key.replace(/([A-Z])/g, "-$1").toLowerCase();
summary[crashlyticsKey] = safeStringify(value);
count += 1;
}
}
Collaborator
Author
There was a problem hiding this comment.
According to the Airbnb JavaScript style guide, for-of and for-in loops should be avoided in favor of array iteration methods like .map(), .forEach(), and .reduce().
airbnb/javascript#1271
Collaborator
There was a problem hiding this comment.
I think that depends on the use case. Here's a detailed explanation by chatgpt
https://chatgpt.com/share/693a69a9-40d4-8010-833b-6808e4fc4d6e
Collaborator
There was a problem hiding this comment.
@amitojsingh what did we change here? Did we change anything?
Collaborator
Author
There was a problem hiding this comment.
replaced the code.
|
|
||
| useEffect(() => { | ||
| // Track screen view when error fallback is shown | ||
| trackScreenView("ErrorFallback", null, "Error Boundary Fallback Screen"); |
Collaborator
There was a problem hiding this comment.
Why aren't we using the constant variable constant.FALLBACK here?
…king - Updated FallbackComponent to use a constant for screen tracking. - Enhanced Navigation component to handle state changes more robustly, including error logging for performance trace failures and improved screen view tracking.
- Replaced Object.entries with a for...of loop for better readability and performance. - Updated logic to skip undefined values using continue statement, improving clarity of the code.
Gauravjeetsingh
approved these changes
Dec 18, 2025
* Enhance audio tracking and language validation in HomeScreen and AudioPlayer components - Added language validation logic in HomeScreen to ensure valid language selection. - Integrated new analytics tracking for audio events, including artist listening duration and audio requests. - Updated AudioControlBar to utilize the new useArtistListeningDuration hook for tracking listening time. - Refactored AudioTrackDialog to include analytics tracking for audio link requests. - Improved import structure in various components for better organization and clarity. * fixed
- Integrated analytics tracking for audio link requests by adding trackAudioEvent. - Updated buttonPress logic to handle errors gracefully when opening the audio request URL. - Improved user experience by ensuring a fallback mechanism for URL opening failures.
smanjot27
pushed a commit
to manjotkaur27/sundar-gutka-react
that referenced
this pull request
Mar 28, 2026
* Improved the analytics and log events. * Refactor FallbackComponent and Navigation for improved analytics tracking - Updated FallbackComponent to use a constant for screen tracking. - Enhanced Navigation component to handle state changes more robustly, including error logging for performance trace failures and improved screen view tracking. * Refactor summarizeState function in crashlytics middleware - Replaced Object.entries with a for...of loop for better readability and performance. - Updated logic to skip undefined values using continue statement, improving clarity of the code. * Added analytics for Sundar Gutka Audio (KhalisFoundation#351) * Enhance audio tracking and language validation in HomeScreen and AudioPlayer components - Added language validation logic in HomeScreen to ensure valid language selection. - Integrated new analytics tracking for audio events, including artist listening duration and audio requests. - Updated AudioControlBar to utilize the new useArtistListeningDuration hook for tracking listening time. - Refactored AudioTrackDialog to include analytics tracking for audio link requests. - Improved import structure in various components for better organization and clarity. * fixed * fix: test * Enhance audio link request tracking in AudioPlayer component - Integrated analytics tracking for audio link requests by adding trackAudioEvent. - Updated buttonPress logic to handle errors gracefully when opening the audio request URL. - Improved user experience by ensuring a fallback mechanism for URL opening failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier, multiple events were being recorded for the same screen, so this update will resolve that issue.
Another issue was that Sundar Gutka screens were being recorded directly from React Native instead of the proper navigation flow, and I’ve fixed that as well in this PR.