Fix: Reader Position Not Preserved on Theme / Font Size Change#375
Open
devprabhsingh4590 wants to merge 2 commits into
Open
Fix: Reader Position Not Preserved on Theme / Font Size Change#375devprabhsingh4590 wants to merge 2 commits into
devprabhsingh4590 wants to merge 2 commits into
Conversation
Removed comments regarding Push Notifications capability for clarity.
Gauravjeetsingh
requested changes
Mar 9, 2026
| "-lc++", | ||
| ); | ||
| PRODUCT_BUNDLE_IDENTIFIER = com.WahegurooNetwork.SundarGutka; | ||
| PRODUCT_BUNDLE_IDENTIFIER = com.WahegurooNetwork.SundarGutka.prabh; |
Collaborator
There was a problem hiding this comment.
I think these changes are pushed by mistake, can you please revert them.
| <string>UIInterfaceOrientationLandscapeLeft</string> | ||
| <string>UIInterfaceOrientationLandscapeRight</string> | ||
| </array> | ||
| <key>UIViewControllerBasedStatusBarAppearance</key> |
Collaborator
There was a problem hiding this comment.
Any reason for these changes? If there isn't any change, just position change, can we please revert these too.
|
|
||
| const scrollFunc=(e)=> { | ||
| const elementId = getTopmostElementId(); | ||
| const elementId = getBottommostElementId(); |
Collaborator
There was a problem hiding this comment.
@devprabhsingh4590 veerji, can you please share some context here, why did we change from topmost element to the bottommost element?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the issue by adding getTopmostElementId to correctly detect the topmost visible text element during scroll and orientation changes.