-
Notifications
You must be signed in to change notification settings - Fork 16
Audio System Refactor: Playback Stability, Background Service, Sync Optimisation, UI enhancement & Testing Improvements #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
manjotkaur27
wants to merge
117
commits into
KhalisFoundation:dev
Choose a base branch
from
manjotkaur27:fix-trackplayer-interactions
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
117 commits
Select commit
Hold shift + click to select a range
febee98
fixes extra gap b/w lines in paragraph mode off
MySmilingTurban ca5c528
fixes extra gap b/w lines in paragraph mode off
MySmilingTurban c05162c
fix: trackplayer interactions and performance optimisations
manjotkaur27 255b941
fix: inverse playback speed buttons, track stopping on switching menu…
manjotkaur27 9d4a98f
fix: incorrect track current and total duration displayed sometimes
manjotkaur27 9277cfc
fix: progress bar of audio takes time to update when coming back from…
manjotkaur27 bbc66c6
fix: add hyperlink indication ui to request bani audio
manjotkaur27 2fd909d
Audio starts auto playing when its paused after a new app audio/calls
manjotkaur27 a4510cf
fix: Increase/decrease in volume causes audio to pause (intermittent)
manjotkaur27 e5caff8
fix: incorrect track durations, revert enable audio play in other menus
manjotkaur27 363fc5e
fix: bg audio play mixes with other audio, incorrect audiop duration
manjotkaur27 8626cf1
Delete manifest-endpoint-audit.csv
bhuveshx 47f0a1f
Delete json-availability-audit.csv
bhuveshx a3e4578
fix: translation and transliteration setting flows
manjotkaur27 db56abe
fix: artist pick preview, add tests
manjotkaur27 457af55
fix: audio player and autoplay setting flows
manjotkaur27 4886eb0
fix: bani 6 api, bani starting not starting in read mode
manjotkaur27 54783e9
fix: manual test cases bugs
manjotkaur27 3a5f661
selected artist in preview should start audio withoout pressign play
manjotkaur27 efeb07a
fix: cache limit to 5 last played tracks, remove sync scroll in preview
manjotkaur27 fb3cd4d
add new audios and jsons
manjotkaur27 a33317d
fix: sync w/ scroll, remember sync preference, no internet falbacks
manjotkaur27 498a04c
fix: connection loss fallbacks
manjotkaur27 07c78a7
fix: preview issues
manjotkaur27 3d7c9be
fix: seeking issues
manjotkaur27 c40d5cc
fix: artist cache rem
manjotkaur27 302a880
fix: post menu browse preview list popup open fail
manjotkaur27 a988833
fix: bg play:
manjotkaur27 9d56a30
fix: update test scripts
manjotkaur27 be2ed31
Delete generate_test_map.py
bhuveshx 4a9fbe6
fix: WebView fix for iOS
manjotkaur27 deff66d
fix: settings page alighments, transliteration and translation menu size
manjotkaur27 b13958b
fix: added icon/art cosmetics to noti track player
manjotkaur27 4ed7a3a
fix: duck and call/alarm flows, bani name in noti audio player
manjotkaur27 1abcd4d
fix: scrollbar color inconsistency
manjotkaur27 2c9302e
fix: autoscroll component
manjotkaur27 339a872
fix: mutex autoscroll and audio player
manjotkaur27 7eb3074
fix: 250ms polling for progress for snappy sync scroll
manjotkaur27 9476676
fix: immersive mode and fix navbar size
manjotkaur27 5d69b6a
add new jsons and mp3 urls
manjotkaur27 c2d105b
fix: button bgs on iOS
manjotkaur27 9fea116
fix: bani name in noti player
manjotkaur27 2550a0e
fix: mute issue on large audios
manjotkaur27 27e6e25
ship with sync scroll ON
manjotkaur27 7034a7c
json bundle, network improvements
manjotkaur27 6bf099f
fix iOS back icon background
manjotkaur27 782aa81
add giani gurdev ji audios, add horizontal read progress, fix muting …
manjotkaur27 b9e8b51
fix: update test scripts for new code
manjotkaur27 4544bd5
revert to slider for auto-scroll component
manjotkaur27 95f8ee3
add audio enable in navbar in autoscroll mode, fix gap in multi-optio…
manjotkaur27 2eabba7
fix: downloading indicator, revert to native bridge progress bar
manjotkaur27 d3444d2
shift constants to constant.js, add hindi locale for RELOADING_BANI
manjotkaur27 2de630c
revert to old design for sync scroll, fix navbar interaction with audio
manjotkaur27 2330e6b
fix: faster checking and synchronous guard for sync scroll
manjotkaur27 3cd2f0b
add missing data for Giani Gurdev Singh ji
manjotkaur27 0343db5
FIX: Audio & text discrepency bug fix
smanjot27 ba781ba
fix: increase speed of autoscroll, autoscroll dialog box content size
manjotkaur27 c0d74a6
fix: sync scroll on android by shifting whole app to .m4a audio files
manjotkaur27 d58bb1a
chore: remove unused imports, variables and dead duckPauseTimer code
manjotkaur27 38b9e3b
Update README
manjotkaur27 5552448
fix: call pause() instead of reset () on RemoteDuck
manjotkaur27 bdea378
fix: bg play in iOS with another app in focus
manjotkaur27 90dd846
Revert "fix: bg play in iOS with another app in focus"
smanjot27 55cbe5c
FIX: iOS player functioning in notification panel
manjotkaur27 21b5ec1
add fixed japji sahib json for bhai jarnail singh
manjotkaur27 2911600
fix: scroll and next button in artist list
manjotkaur27 0e6cb0c
fix: error/disable message popups text and theme
manjotkaur27 4af4a4a
fix: network error popup, unintended resume on autoplay off
manjotkaur27 dd4b1c5
fix: Gurbani Akhar Thick font face typo
manjotkaur27 1093b25
fix: bani folder pages names in different transliteration
manjotkaur27 0d96808
Fix: Appbar Modification in Bookmark screen for iOS
manjotkaur27 1da9626
fix: autoplay behaviour on calls, japji sahib pauri 34 incorrect string
manjotkaur27 67a70f8
fix: x padding
manjotkaur27 2843936
fix bookmark appbar color in light mode
manjotkaur27 f323498
fix: autoplay on interactions on focus gain
manjotkaur27 95f8a5b
Improvement: Consistent Toggle UI in android & iOS in both modes (No …
manjotkaur27 fe5d393
fix: Status bar icon & visibility according to toggle
manjotkaur27 2cfc9fc
fix: instantl sync of autoscroll& keep screen awake toggle
manjotkaur27 ff2ba1a
fix: preserve read context when switching to paragraph mode in auto s…
manjotkaur27 91612a8
fix: cache read progress in auto scroll in closed & terminated app state
manjotkaur27 989d83f
FIX:
manjotkaur27 74813ee
fix: bani length mapping holds true of audios when avail
manjotkaur27 42c1ebb
FIX:
manjotkaur27 fc545d0
fix: audio should not play in background when auto play is on & bani …
manjotkaur27 5c9522e
iOS Compatibility fixes
manjotkaur27 f22fc62
fix: update test scripts and add fix for iPad read progress
manjotkaur27 82f7e36
Fix: Notification player & read progress cache in iPad
manjotkaur27 1df8ca0
Fix: audio should not resume in background on change bani length from…
manjotkaur27 5c91aeb
activate bani id 1000, anand sahib 6 pauri
manjotkaur27 def9384
fix: remove explicit toggle messages, length/avail based Maafi message
manjotkaur27 36599ce
fix: Google form for Maafi page, fix higlight width and english trans…
manjotkaur27 db94548
fix: multi higlight in sync scroll
manjotkaur27 64a4940
fix: onboarding resize
manjotkaur27 b5b8f52
fix: trimmed banis audio lengths, dynamic length maafi message
manjotkaur27 4ea9589
fix: audio end should reset player
manjotkaur27 91383f2
fix: text visiblity when language is changed
manjotkaur27 8a50094
fix: perserve selected language even when app is closed
manjotkaur27 73fe8cd
fixes
manjotkaur27 37ef164
fix: stale progress on bani length change
manjotkaur27 3dbb591
fix: switch japji sahib m4a/json bhai jarnail singh
manjotkaur27 53b973e
fix highlight behaviour on focus loss and pause + add logging
manjotkaur27 122b40e
fix: audio button visibilitiy on manual autoscroll toggle off
manjotkaur27 98996a4
fix: flash of saved progress from other last played track
manjotkaur27 af77664
fix: progress update
manjotkaur27 1695583
fix: iOS bugs
manjotkaur27 01f6a74
fix: consistent artist names, warning on Baloo Paaji font selection
manjotkaur27 6c33d05
keep original tracks only for length affected banis
manjotkaur27 8732efe
fix: analytics, tests
manjotkaur27 b7292db
fix: prevent ForegroundServiceStartNotAllowedException crash on Andro…
manjotkaur27 65a9f32
fix: notification ducking, add bani_title to track_download firebase …
manjotkaur27 4aaa86a
fix: guard corrupt/partial downloads — validate against trackSizeMB b…
manjotkaur27 0516a6b
Add PROJECT_STRUCTURE.md
manjotkaur27 1be9cd9
Improvements requested in Review:
manjotkaur27 ea0e97e
feat(reader): hide bottom nav with the header on tap/scroll
manjotkaur27 1b88695
feat(audio): serve audio/lyrics from the Azure Front Door CDN
manjotkaur27 8ae593b
Improvements
manjotkaur27 f85df3a
Improvementts: Hide Nav Bar on scroll & tap
manjotkaur27 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <resources> | ||
| <color name="primary_dark">#2a3381</color> | ||
| <color name="primary_dark">#113979</color> | ||
| <color name="primary_variant">#171d47dd</color> | ||
| <color name="primary_accent">#5195ea</color> | ||
| </resources> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.