Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unusable asciidoc attribute #534

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

etomzak
Copy link
Contributor

@etomzak etomzak commented Feb 2, 2024

I think the intent here is to provide a plural alias for the work-item glossary term. Since this attribute is defined at the very end of the spec, though, it's not used anywhere and not usable anywhere.

If this alias is needed, then it needs to be defined somewhere like adoc/config/attribs.adoc.

@CLAassistant
Copy link

CLAassistant commented Feb 2, 2024

CLA assistant check
All committers have signed the CLA.

@keryell keryell added the editorial Some purely editorial problem label Feb 8, 2024
Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
But as you suggest, perhaps a solution is to advertise more adoc/config/attribs.adoc and its neighborhood and put this definition there instead of being at the beginning of adoc/syclbase.adoc?

@gmlueck
Copy link
Contributor

gmlueck commented Feb 22, 2024

Merging this as editorial.

@gmlueck gmlueck merged commit f812749 into KhronosGroup:SYCL-2020/master Feb 22, 2024
2 checks passed
keryell pushed a commit that referenced this pull request Sep 10, 2024
Remove unusable asciidoc attribute
gmlueck added a commit that referenced this pull request Nov 7, 2024
Remove unusable asciidoc attribute

(cherry picked from commit f812749)
gmlueck added a commit that referenced this pull request Nov 7, 2024
Remove unusable asciidoc attribute

(cherry picked from commit f812749)
@etomzak etomzak deleted the remove_wi_attrib branch November 27, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Some purely editorial problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants