Clarify max work-group size #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify the two information descriptors: * `info::device::max_work_group_size` * `info::kernel_device_specific::work_group_size` These queries correspond to the OpenCL queries `CL_DEVICE_MAX_WORK_GROUP_SIZE` and `CL_KERNEL_WORK_GROUP_SIZE`, and I shamelessly stole much of the description from the OpenCL specification.
Pennycook
reviewed
Apr 5, 2024
Co-authored-by: John Pennycook <[email protected]>
|
We need some more reviewers on this also. |
AerialMantis
approved these changes
May 16, 2024
nliber
approved these changes
Jun 13, 2024
|
Nevin was faster than me! |
gmlueck
pushed a commit
that referenced
this pull request
Nov 7, 2024
Clarify max work-group size (cherry picked from commit 6636940)
gmlueck
pushed a commit
that referenced
this pull request
Nov 7, 2024
Clarify max work-group size (cherry picked from commit 6636940)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify the two information descriptors:
info::device::max_work_group_sizeinfo::kernel_device_specific::work_group_sizeThese queries correspond to the OpenCL queries
CL_DEVICE_MAX_WORK_GROUP_SIZEandCL_KERNEL_WORK_GROUP_SIZE, and I shamelessly stole much of the description from the OpenCL specification.