fix[build]: windows packages build#44
Conversation
WalkthroughThe changes include: (1) addition of a dependency override for Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
packages/rwa/tsconfig.declaration.json (1)
1-10: Dedicated declarations config looks good.The options are appropriate for a declarations-only pass. Optionally add composite if you plan to use project references later, otherwise keep as-is.
Apply if desired:
"compilerOptions": { "outDir": "./dist", "declaration": true, "emitDeclarationOnly": true, "isolatedModules": false, - "preserveConstEnums": false + "preserveConstEnums": false + // "composite": true }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (5)
package.json(1 hunks)packages/evm/package.json(1 hunks)packages/proto/package.json(1 hunks)packages/rwa/package.json(1 hunks)packages/rwa/tsconfig.declaration.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: analyze
🔇 Additional comments (4)
packages/evm/package.json (1)
25-25: LGTM: unquoting the glob improves Windows compatibility.Prettier handles the pattern; removing single quotes avoids issues in cmd.exe/PowerShell. No further action needed.
packages/rwa/package.json (2)
34-34: LGTM: rimraf dist is safer cross-platform than dist/.**
37-38: Confirm whether codegen is required for release builds (add to build if so).build:dev runs
npm run codegenbutbuilddoes not — a clean-clone or CI build may miss generated sources and fail.File: packages/rwa/package.json (lines 37–38)
Suggested diff:
- "build": "npm run clean && tsc && tsc -p tsconfig.declaration.json && npm run copy", + "build": "npm run clean && npm run codegen && tsc && tsc -p tsconfig.declaration.json && npm run copy",packages/proto/package.json (1)
33-33: LGTM: simplified clean script is correct and avoids glob quirks on Windows.
|
@isonnymichael thanks for the contribution. Why the addition of glob? |
|
This is strange — previously I couldn’t build, but after merging to the main branch, resolving the conflicts, and removing glob, I can now build successfully on my Windows device. @GiovaniGuizzo |
|
Yes, I fixed a few things in the repo a few weeks back. I also use Windows. |
|
okay, @GiovaniGuizzo
|
|
Yes, there is: https://lcd.uno.sentry.testnet.v3.kiivalidator.com/ |
okay thanks |


Description
This PR fixes build issues on Windows for the
protoandrwapackages.It also resolves a conflict with the root-level glob in the repository that caused the
copyfilescommand to fail.Changes ensure that build scripts are now cross-platform and work on Windows, macOS, and Linux.
Summary of changes:
globdependency inpackage.jsontsconfig.declaration.jsonfor the RWA packagecopycommand path in theprotopackagecleanandbuildscripts in the RWA package to use the newtsconfigType of change
How Has This Been Tested?
protoandrwapackages on Windows successfullycopyfilesruns without conflictScreenshots of error before fix
Fixed scripts example
Also added missing
tsconfig.declaration.jsonfile in rwa.