Skip to content

Conversation

@EamonNerbonne
Copy link
Contributor

No description provided.

@EamonNerbonne EamonNerbonne requested a review from Copilot October 9, 2025 15:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR optimizes autocomplete filtering test performance by removing artificial delays and enabling a force parameter to skip debouncing during tests.

  • Removed the beforeEach hook that added a 50ms delay between each test
  • Added a force=true parameter to skip debounce logic in the completion provider

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
core/autocomplete/filtering/test/util.ts Added force parameter to skip debounce in test utility
core/autocomplete/filtering/test/filter.vitest.ts Removed beforeEach delay hook to speed up test execution

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

github-actions bot commented Oct 9, 2025

⚠️ PR Title Format

Your PR title doesn't follow the conventional commit format, but this won't block your PR from being merged. We recommend using this format for better project organization.

Expected Format:

<type>[optional scope]: <description>

Examples:

  • feat: add changelog generation support
  • fix: resolve login redirect issue
  • docs: update README with new instructions
  • chore: update dependencies

Valid Types:

feat, fix, docs, style, refactor, perf, test, build, ci, chore, revert

This helps with:

  • 📝 Automatic changelog generation
  • 🚀 Automated semantic versioning
  • 📊 Better project history tracking

This is a non-blocking warning - your PR can still be merged without fixing this.

@EamonNerbonne EamonNerbonne merged commit 3d7aaf1 into main Oct 9, 2025
49 of 54 checks passed
@EamonNerbonne EamonNerbonne deleted the eamon/timenotout branch October 10, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants