Skip to content

Use forge load order. #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BluSpring merged 2 commits into from
May 16, 2026
+17 −1
Merged

Use forge load order. #746

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bccace9
Use forge load order.
Acuadragon100 Apr 28, 2026
bb1ae09
Sort by hash keys instead.
Acuadragon100 May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/main/kotlin/xyz/bluspring/kilt/loader/KiltLoader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,9 +479,25 @@ class KiltLoader : KnitModLoader<ForgeMod>(Kilt.MOD_ID, "Forge") {
}
}

// Copied from HashMap::hash
fun hash(key: Any?): Int {
val h: Int
return if (key == null) 0 else (key.hashCode().also { h = it }) xor (h ushr 16)
}

/**
* Forge mods are sorted based on the order of keys in a hash map.
* See: https://github.com/MinecraftForge/MinecraftForge/blob/1.20.1/fmlloader/src/main/java/net/minecraftforge/fml/loading/UniqueModListBuilder.java#L42
* This won't sort the mods in exactly the same order, but it will be close enough to hopefully resolve most issues caused by mods not explicitly denoting their dependencies.
* Users can always explicitly override this order with dependency overrides.
*/
fun getForgeNaturalOrder(): Comparator<ForgeMod> {
return Comparator.comparing { hash(it.modId) }
}

override fun finishModScanning() {
val graph = this.mods.buildGraph()
val sorted = TopologicalSort.topologicalSort(graph, null)
val sorted = TopologicalSort.topologicalSort(graph, getForgeNaturalOrder())

// Sort the mods, otherwise stuff breaks.
val modsRef = this.mods as MutableList<ForgeMod>
Expand Down