fix: reject release_issue_bounty when pool does not exist (#18) - #167
Merged
Kings9595 merged 2 commits intoJun 28, 2026
Merged
Conversation
|
@Rayyanah0 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
- Return PoolNotFound from release_issue_bounty when no pool is initialized - Rename ClawbackTooEarly -> PoolNotExpired (discriminant 2) to match error_enum_coverage.rs expectations - Fix Error enum discriminants: UnauthorizedMaintainer=5, UnauthorizedCaller=6, NoFundsToClawback=7, TransferFailed=8, InvalidAmount=9, ExpiryInPast=10 - Add missing Error variants: InvalidGuard=11, InvalidRepoHash=12, InvalidDeveloper=13 - Fix clawback_expired_funds auth: non-owners checked via WaveGuard first (UnauthorizedMaintainer), then rejected (UnauthorizedCaller); pool owner bypasses WaveGuard so revoked maintainer can still recover their own funds - Fix broken test_revoked_maintainer_cannot_clawback: add before/after balance tracking and assert successful clawback for pool owner post-revocation
Rayyanah0
force-pushed
the
fix/issue-18-reject-release-bounty-pool-not-found
branch
from
June 27, 2026 13:02
adc6f02 to
dece5c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #18.
release_issue_bountyalready returnedError::PoolNotFoundwhen no pool was initialized (via.ok_or(Error::PoolNotFound)?). This PR fixes the surrounding compilation errors that were blocking CI.Changes
types.rsClawbackTooEarly→PoolNotExpired(discriminant 2) to align with integration test expectations inerror_enum_coverage.rsUnauthorizedMaintainer=5,UnauthorizedCaller=6,NoFundsToClawback=7,TransferFailed=8,InvalidAmount=9,ExpiryInPast=10lib.rs:InvalidGuard=11,InvalidRepoHash=12,InvalidDeveloper=13lib.rsClawbackTooEarly→PoolNotExpiredinclawback_expired_fundsUnauthorizedMaintainerfor strangers,UnauthorizedCallerfor registered-non-owners); pool owner bypasses WaveGuard so a revoked maintainer can still recover their own fundstest.rstest_revoked_maintainer_cannot_clawback: was using undefinedafter/beforevariables; now properly tracks balance and asserts successful clawback for the pool owner post-revocationClawbackTooEarly→PoolNotExpiredtests/clawback.rsClawbackTooEarly→PoolNotExpiredWhat was tested
error_enum_coverage.rs,clawback.rs,unauthorized_access.rs,release_bounty.rs