fix(api): stop logging full user (incl. password hash) on update#63
Conversation
The debug println! in UserRepository::update printed the entire User struct, including email and bcrypt password_hash, to stdout on every email/password/network change. This leaked credentials into container and aggregated logs and bypassed the tracing setup. Removed it. Closes #37
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughA debug ChangesDebug Print Removal
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
Removes a debug
println!("Updating user: {:?}", user)inUserRepository::updatethat printed the entireUserstruct — includingemailand the bcryptpassword_hash— to stdout on every email change, password change, password reset, and network switch.Why
tracingsetup used everywhere else.Changes
println!in user_repository.rs.Testing
cargo check --workspacepasses.Closes #37
Summary by CodeRabbit
Release Notes