fix(api): make /auth/health a conventional GET JSON endpoint#71
Conversation
The auth router exposed health as POST("Welcome to txio") — an obscure
string-as-handler that standard GET health probes never hit, with wording
inconsistent with the top-level GET /health. Make it a GET returning
{"status":"ok"}.
Closes #62
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe auth router's ChangesHealth endpoint conversion
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
auth_routerregistered health asPOST("Welcome to txio")— a bare-string-as-handler that standardGEThealth probes never reach, duplicating the top-levelGET /health(main.rs) with different semantics/wording.Changes
GET /api/v1/auth/healthreturning{"status":"ok"}.Testing
cargo check -p txio-apipasses.Closes #62
Summary by CodeRabbit