refactor: enable compile-time D-Bus signature generation #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangelovic
force-pushed
the
refactor/constexpr-signature-type-traits
branch
from
1c5399f to
682e2ff
Compare
sangelovic
force-pushed
the
refactor/constexpr-signature-type-traits
branch
from
682e2ff to
a4d2c85
Compare
sangelovic
force-pushed
the
refactor/strong-types
branch
2 times, most recently
from
02a8376 to
21b250e
Compare
sangelovic
force-pushed
the
refactor/constexpr-signature-type-traits
branch
4 times, most recently
from
a2a82a2 to
7867526
Compare
sangelovic
force-pushed
the
release/v2.0
branch
from
71674bb to
98662af
Compare
sangelovic
force-pushed
the
refactor/constexpr-signature-type-traits
branch
from
7867526 to
dc6283e
Compare
sangelovic
changed the title
sangelovic
force-pushed
the
refactor/constexpr-signature-type-traits
branch
from
dc6283e to
598eb23
Compare
sangelovic
force-pushed
the
refactor/constexpr-signature-type-traits
branch
from
598eb23 to
f44e113
Compare
sangelovic
added a commit
that referenced
this pull request
Apr 16, 2024
Since sdbus-c++ knows types of D-Bus call/signal/property input/output parameters at compile time, why not assemble the D-Bus signature strings at compile time, too, instead of assembling them at run time as std::string with likely cost of (unnecessary) heap allocations... std::array is well supported constexpr type in C++20, so we harness it to build the D-Bus signature string and store it into the binary at compile time.
sangelovic
added a commit
that referenced
this pull request
Apr 16, 2024
Since sdbus-c++ knows types of D-Bus call/signal/property input/output parameters at compile time, why not assemble the D-Bus signature strings at compile time, too, instead of assembling them at run time as std::string with likely cost of (unnecessary) heap allocations... std::array is well supported constexpr type in C++20, so we harness it to build the D-Bus signature string and store it into the binary at compile time.
sangelovic
added a commit
that referenced
this pull request
Apr 24, 2024
Since sdbus-c++ knows types of D-Bus call/signal/property input/output parameters at compile time, why not assemble the D-Bus signature strings at compile time, too, instead of assembling them at run time as std::string with likely cost of (unnecessary) heap allocations... std::array is well supported constexpr type in C++20, so we harness it to build the D-Bus signature string and store it into the binary at compile time.
sangelovic
added a commit
that referenced
this pull request
Apr 24, 2024
Since sdbus-c++ knows types of D-Bus call/signal/property input/output parameters at compile time, why not assemble the D-Bus signature strings at compile time, too, instead of assembling them at run time as std::string with likely cost of (unnecessary) heap allocations... std::array is well supported constexpr type in C++20, so we harness it to build the D-Bus signature string and store it into the binary at compile time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since sdbus-c++ knows types of D-Bus call/signal/property input/output parameters at compile time, why not assemble the D-Bus signature strings at compile time, too, instead of assembling them at run time as
std::stringwith likely cost of (unnecessary) heap allocations...std::arrayis well supportedconstexprtype in C++20, so we harness it to build the D-Bus signature string and store it into the binary at compile time.