-
Couldn't load subscription status.
- Fork 27
[643] Moved unit type from municipality ranked list to heading #1112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an idea, what do you think about having a heading type row under the search and above the list for Municipality Name on the left and Tonnes CO2e on the right above the numbers (or whatever unit is relevant?). Though.... thinking about the Boolean values not sure that works, unless we can find a generic title/label....
Just not sure how I feel about the unit being so separated from the values in the current version, but maybe it's clear enough for people to realize it applies across all values on the page 🤔
Very good point. I could do a version and print screen where we have just that. The boolean could be just fine though not being there as they're quite self explanatory? |
|
Something like this? @kaylawoodbury
|
|
Yeah exactly! Wondering if we want the unit the same colour as the "Name" label wdyt? But what do you think of this placement vs being kpi description? I can see benefits for both, and curious how this looks for the top and bottom 5 lists 🤔 |
I like this version more, where we have the "Name" and unit, and as you said, in the same color. Not sure what it would look like for those lists, then again, since it's only 5 companies/municipalities, perhaps it's not a big deal with repeated % there? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of extra spaces/lines, but otherwise looks good! Feel free to merge 🚀
Co-authored-by: Kayla Woodbury <[email protected]>
Co-authored-by: Kayla Woodbury <[email protected]>


✨ What’s Changed?
Moved the repeated units from the municipality ranked list view to instead be explained in the heading of the selected KPI. This as an idea request #643 where the list felt a bit overwhelming with the repeated units. Could be done like this, but there's several ways to do it. If you have any other thoughts or ideas LMK!
📸 Screenshots (if applicable)
📋 Checklist
🛠 Related Issue
Closes #643