Skip to content

Conversation

@CarlWiren90
Copy link
Collaborator

✨ What’s Changed?

Moved the repeated units from the municipality ranked list view to instead be explained in the heading of the selected KPI. This as an idea request #643 where the list felt a bit overwhelming with the repeated units. Could be done like this, but there's several ways to do it. If you have any other thoughts or ideas LMK!

📸 Screenshots (if applicable)

image image

📋 Checklist

  • PR title starts with [#issue-number]; if no issue is applicable use: [fix], [feat], [prod], or [copy]
  • I've verified the change runs locally both on mobile and desktop
  • I've set the labels, issue, and milestone for the PR

🛠 Related Issue

Closes #643

@CarlWiren90 CarlWiren90 self-assigned this Oct 20, 2025
@CarlWiren90 CarlWiren90 added the enhancement New feature or request label Oct 20, 2025
Copy link
Contributor

@kaylawoodbury kaylawoodbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an idea, what do you think about having a heading type row under the search and above the list for Municipality Name on the left and Tonnes CO2e on the right above the numbers (or whatever unit is relevant?). Though.... thinking about the Boolean values not sure that works, unless we can find a generic title/label....

Just not sure how I feel about the unit being so separated from the values in the current version, but maybe it's clear enough for people to realize it applies across all values on the page 🤔

@CarlWiren90
Copy link
Collaborator Author

As an idea, what do you think about having a heading type row under the search and above the list for Municipality Name on the left and Tonnes CO2e on the right above the numbers (or whatever unit is relevant?). Though.... thinking about the Boolean values not sure that works, unless we can find a generic title/label....

Just not sure how I feel about the unit being so separated from the values in the current version, but maybe it's clear enough for people to realize it applies across all values on the page 🤔

Very good point. I could do a version and print screen where we have just that. The boolean could be just fine though not being there as they're quite self explanatory?

@CarlWiren90
Copy link
Collaborator Author

Something like this? @kaylawoodbury

image

@kaylawoodbury
Copy link
Contributor

Yeah exactly! Wondering if we want the unit the same colour as the "Name" label wdyt?

But what do you think of this placement vs being kpi description? I can see benefits for both, and curious how this looks for the top and bottom 5 lists 🤔

@CarlWiren90
Copy link
Collaborator Author

Yeah exactly! Wondering if we want the unit the same colour as the "Name" label wdyt?

But what do you think of this placement vs being kpi description? I can see benefits for both, and curious how this looks for the top and bottom 5 lists 🤔

I like this version more, where we have the "Name" and unit, and as you said, in the same color.

Not sure what it would look like for those lists, then again, since it's only 5 companies/municipalities, perhaps it's not a big deal with repeated % there?

@kaylawoodbury kaylawoodbury moved this to In review in Klimatkollen main Oct 21, 2025
@CarlWiren90
Copy link
Collaborator Author

Revised:
image

Copy link
Contributor

@kaylawoodbury kaylawoodbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of extra spaces/lines, but otherwise looks good! Feel free to merge 🚀

@CarlWiren90 CarlWiren90 merged commit 6d8ebef into Klimatbyran:main Oct 27, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Klimatkollen main Oct 27, 2025
@CarlWiren90 CarlWiren90 deleted the 643 branch October 27, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Idea] Remove unit/determinator in all lists?

2 participants