Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static champion by ID #65

Merged
merged 5 commits into from
Jun 18, 2024
+161 −58
Merged

Fix static champion by ID #65

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
405c329
Use ID instead of name to fetch static champion info from DataDragon
Apr 27, 2024
e14c68b
Fetch and cache champion data by ID
May 25, 2024
5027718
Merge branch 'master' into fix-static-champion
hanscauwenbergh May 25, 2024
2d59040
Fix tests
May 25, 2024
6fdc29c
Fix tests and linting
Jun 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Loading
Loading status checks…
Use ID instead of name to fetch static champion info from DataDragon
hanscauwenbergh committed Apr 27, 2024
commit 405c3297e0796d1015f1f97f489ada6cca020b54
2 changes: 1 addition & 1 deletion datadragon/data_dragon.go
View file
Original file line number Diff line number Diff line change
@@ -130,7 +130,7 @@ func (c *Client) GetChampionByID(id string) (ChampionDataExtended, error) {
}
for _, champion := range champions {
if champion.Key == id {
return c.GetChampion(champion.Name)
return c.GetChampion(champion.ID)
}
}
return ChampionDataExtended{}, api.ErrNotFound