feat: Allow using custom clusters with groups #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerivec
reviewed
Feb 12, 2025
Nerivec
reviewed
Feb 12, 2025
Nerivec
reviewed
Feb 12, 2025
Koenkk
reviewed
Feb 12, 2025
ccutrer
force-pushed
the
custom-clusters-to-groups
branch
from
a5c090f to
f66199d
Compare
Nerivec
reviewed
Feb 16, 2025
Nerivec
reviewed
Feb 16, 2025
Nerivec
reviewed
Feb 16, 2025
Nerivec
reviewed
Feb 17, 2025
src/zspec/zcl/utils.ts
Outdated
There was a problem hiding this comment.
This shouldn't need to be changed.
Also, considering the changes, and the fact tests are still passing, looks like there are gaps in coverage that are not being properly detected (hence, could be misbehaving from previous logic and we wouldn't know).
Nerivec
reviewed
Feb 17, 2025
But only if ALL devices in the group support the cluster. It's highly dependendt on individual devices if they will support read/write/command for custom clusters. In my testing, my Inovelli switches are responding to writing attributes, but not commands (such as LED commands).
Nerivec
force-pushed
the
custom-clusters-to-groups
branch
from
f66199d to
ebb4385
Compare
|
I'm sorry I haven't had time to get back to this. Other projects have taken priority. I still plan on getting back to it, but don't have a specific estimate as to when. Feel free to finish it yourself if you feel like it warrants it. Otherwise... I'll get to it sometime! |
|
Will finish #1330 first then we can cleanup this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But only if ALL devices in the group support the cluster. It's highly dependent on individual devices if they will support read/write/command for custom clusters. In my testing, my Inovelli switches are responding to writing attributes, but not commands (such as LED commands).