fix: Green Power decryption when received via commissioning notif #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerivec
force-pushed
the
fix-gp-decrypt-zstack
branch
from
2629528 to
f94835a
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback from zstack users with the Moes ZEU2S.
NOTE: Looks like either zstack is incorrectly wrapping the frames, or the GPP is not sending them properly (using
commissioning notificationinstead of regularnotification).Guarded as much as possible to ensure no decryption unless we're reasonably certain it is needed (so, passed as many
optionsas possible for other stacks too).CC: @MaxwellJK