You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Bug Fix (non-breaking change which fixes an issue)
Feature/Tweak (non-breaking change which adds new functionality or enhances existing functionality)
Breaking Change (fix or feature that would break any existing functionality for users)
Documentation Update
Chore (maintenance, dependency bumps, housekeeping - no functional change)
Other
Description
Adds semantic Letterboxd builders for discovery and filmography pages instead of presenting those pages as letterboxd_list inputs. Each builder accepts the relevant Letterboxd slug, constructs the canonical page URL, and then reuses the existing extraction, filtering, pagination, caching, and TMDb mapping path.
collections:
Marlon Brando:
letterboxd_crew:
role: actorperson: marlon-brandoA24:
letterboxd_studio: a24A24 by Release (object form):
letterboxd_studio:
studio: a24sort_by: release_date_newestCrime Films:
letterboxd_genre:
genre: crimelimit: 20Similar to The Godfather:
letterboxd_similar: the-godfather
The string form accepts the slug directly. The object form uses the builder's named slug attribute and supports limit and year; all builders except letterboxd_similar also support sort_by. Validation rejects unsupported crew roles, attributes, and full URLs where a slug is expected.
Testing
Validation
Result
Letterboxd and collection-schema tests
88 passed
Full pytest suite
818 passed
Black
Passed
JSON parsing and git diff --check
Passed
Related Issues [optional]
Related Issue #
Closes #
Have you updated the Documentation to reflect changes (if necessary)?
Yes
No
Not Applicable
Have you updated the JSON Schema files (if necessary)?
For a lot of the examples you've provided, they aren't really letterboxd_list, they would be new builders like letterboxd_actor, letterboxd_studioletterboxd_genre.
for the cast/crew ones specifically, you could maybe do something like:
letterboxd_crew:
role: actorperson: marlon-brando
letterboxd_crew:
role: director
person: steven-spielberg
For a lot of the examples you've provided, they aren't really letterboxd_list, they would be new builders like letterboxd_actor, letterboxd_studioletterboxd_genre.
for the cast/crew ones specifically, you could maybe do something like:
letterboxd_crew:
role: actorperson: marlon-brando
letterboxd_crew:
role: director
person: steven-spielberg
good Idea, side note do you know why the validate is failing?
For a lot of the examples you've provided, they aren't really letterboxd_list, they would be new builders like letterboxd_actor, letterboxd_studioletterboxd_genre.
for the cast/crew ones specifically, you could maybe do something like:
letterboxd_crew:
role: actorperson: marlon-brando
letterboxd_crew:
role: director
person: steven-spielberg
good Idea, side note do you know why the valitdate is failing?
Seems related to the reason we had to revert the checkout v7 requirement, perhaps they've added enforcement on v6 too - @badja-dev thoughts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Adds semantic Letterboxd builders for discovery and filmography pages instead of presenting those pages as
letterboxd_listinputs. Each builder accepts the relevant Letterboxd slug, constructs the canonical page URL, and then reuses the existing extraction, filtering, pagination, caching, and TMDb mapping path.Builder mapping
letterboxd_crew/actor/marlon-brando/→role: actor,person: marlon-brandoletterboxd_studio/studio/a24/→a24letterboxd_country/films/country/usa/→usaletterboxd_language/films/language/english/→englishletterboxd_genre/films/genre/crime/→crimeletterboxd_theme/films/theme/crime-drugs-and-gangsters/→crime-drugs-and-gangstersletterboxd_similar/film/the-godfather/similar/→the-godfatherletterboxd_collection/films/in/beetlejuice-collection-2/→beetlejuice-collection-2Examples
The string form accepts the slug directly. The object form uses the builder's named slug attribute and supports
limitandyear; all builders exceptletterboxd_similaralso supportsort_by. Validation rejects unsupported crew roles, attributes, and full URLs where a slug is expected.Testing
git diff --checkRelated Issues [optional]
Have you updated the Documentation to reflect changes (if necessary)?
Have you updated the JSON Schema files (if necessary)?
Have you updated the CHANGELOG.md?