tests: Add a simple regression test for sync performance #1622
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a very basic implementation for performance - measuring duration of execution of sync command.
There is code duplication, and it's been implemented to run on only latest enterprise gateway - so needs polishing.
IMO, depending on duration could lead to flaky tests - as network latency is unpredictable.
Ideally, I'd want to have the following in a performance test:
main
available to compare with myfeat/slow-feature
as a comment on my PR - so it's easy to compare what is changing.Feedback and thoughts on how this can be improved welcome 🙏
The test passes on this branch, I'll link another where it fails - based on v1.46.1