Skip to content

tests: Add a simple regression test for sync performance #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

harshadixit12
Copy link
Contributor

@harshadixit12 harshadixit12 commented May 5, 2025

This PR contains a very basic implementation for performance - measuring duration of execution of sync command.
There is code duplication, and it's been implemented to run on only latest enterprise gateway - so needs polishing.

IMO, depending on duration could lead to flaky tests - as network latency is unpredictable.

Ideally, I'd want to have the following in a performance test:

  1. No flakiness
  2. Key performance indicators - CPU consumption, memory consumption, Network throughput, and execution time, for example
  3. Representative state files to measure each - designed to stress each of the key performance indicators
  4. Storing past metrics and easy comparison - for example, i'd want the execution time on main available to compare with my feat/slow-feature as a comment on my PR - so it's easy to compare what is changing.

Feedback and thoughts on how this can be improved welcome 🙏

The test passes on this branch, I'll link another where it fails - based on v1.46.1

@codecov-commenter
Copy link

codecov-commenter commented May 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 28.24%. Comparing base (c409312) to head (083dd51).

Files with missing lines Patch % Lines
tests/performance/utils.go 0.00% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1622      +/-   ##
==========================================
- Coverage   28.34%   28.24%   -0.10%     
==========================================
  Files          67       68       +1     
  Lines        6912     6936      +24     
==========================================
  Hits         1959     1959              
- Misses       4811     4835      +24     
  Partials      142      142              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@harshadixit12 harshadixit12 force-pushed the tests/add-performance-regression-test-for-sync branch from 1971b43 to 083dd51 Compare May 18, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants