Simplify working with optimizer variables #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliabeliaeva
force-pushed
the
optimizer-slots
branch
from
1d6b5d1 to
2e20635
Compare
|
It's an interesting proposal, but I need a time to estimate the power of this refactoring, give me a couple of days here to trace all the code routes in refactored optimizers |
|
@zaleslaw I don't think this refactoring should be included into the 0.4 so there is really no rush with the review. |
|
If you suppose to postpone it, I suggest marking it with the 0.5 milestone |
Create optimizer variables directly at the place they are used.
juliabeliaeva
force-pushed
the
optimizer-slots
branch
from
d2eb7fe to
96ed53d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deals with optimizer variables created by the
createSlotfunction. Instead of creating variables in theOptimizer#createSlots, putting them to the special map only to retrieve in theapplyGradients, which is called directly after, variables are created immediately before usage.