Correct the name of k/wasm target in README.md #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When following a README.md it's convenient when the snippets are up-to-date
eymar
changed the title
Collaborator
|
@eymar, thanks for opening the PR. The plugin already shows a warning when a non-existing target is registered, for example:
Note that the README is correct:
But yeah, the README should use up-to-date target names. Could you please also update this line to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasm->wasmJsWhen following README.md it's convenient when the snippets are up-to-date.
Btw, it might be even more convenient if the plugin would show a warning or even an error when a registered target doesn't exist.