-
Notifications
You must be signed in to change notification settings - Fork 720
Add text alignment support #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for the adition, @ricardopereira! Did you consider to not only align the text but the icon too? I could imagine this to work analog to the This isn't about these changes but more of a general issue I see: I think we need to keep the designated initializer from growing, as every new feature/property gets added onto it. This would be kind of a bigger change I image which would also break the public API, but I think it makes sense to discuss it in a separate issue - what do you think @KrauseFx ? |
Yes, that's exactly what I'm concerned about. The designated initialiser grows and grows. There is already an issue with some thoughts about that: #54 I guess a major redesign of the TSMessages library would be necessary for this change. |
I will abort this pull request and rethink about it. |
Well, it's not something that's your fault or your job. It's something I've been unhappy with TSMessages for a long time now. @dennisreimann and me are working on a better solution, where we can add your great new option for text alignment as well. Thanks for your contribution 👍 |
That's ok. You welcome. I also close it because I made the mistake of committing the feature on the master. I forget to create a new branch. I'm just getting used with github :) Sorry about that. |
@dennisreimann this feature should be in 1.0 |
Yes, @KrauseFx already assigned it to that milestone :) Right now I don't have any time to work on TSMessages though... :( |
HexColors in 2.3 version has renamed his file hexColor.h to hexColors.h Also, now we can align the text in the TSMessage - Rename import hexColors.h in TSMessageView - Update in methods with textAlign property in the TSDemoViewController
Bugfix/hexcolors updated + TSBlurView to UIView
hello. how can i get this pull? current project still display text in left ( ipad) |
@fukemy You can use my fork like |
@fukemy TSMessages is no longer being updated/maintained. We are recommending people migrate to RMessage which for the most part maintains full compatibility with TSMessages apart from embedding a UIButton. Please see the README.md of this repo. As of 2.1.3 RMessage supports text alignment (both the title and subtitle) via the design file and appearance proxy. So check that out. Version 3.0.0 which is not 'master' yet does have support for the UIButton (more generally embedding UIViews). |
@ricardopereira i used your code then got this problem. the notify run from bottom -> top. It's not show here is my code: |
@fukemy Please use this one https://github.com/donileo/RMessage. |
(NSTextAlignment) messageAlign
It’s possible to change the alignment on initWithTitle and customize it
on the layout:
The layout has priority.
Examples updated too!