Update netCDF datasource plugin to work with modern netCDF4 C++ bindings #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We (South Pole Telescope) occasionally need to generate netCDF data for live viewing with kst2. Kst2 is by far the most efficient tool for live streaming detector data, but the netCDF plugin is quite out of date, and our netCDF data generator creates files in the newer netCDF4 format. This PR is meant to update the netCDF datasource plugin to link against the netCDF4 C++ bindings instead of the older version.
I am currently at pole, and unfortunately don't have the (electronic or mental) bandwidth to figure out how to update the build system properly to integrate into the CI or packaging framework, but I wanted to at least get this code posted for review / integration into later releases if possible. I've enabled edits by maintainers on this branch, so feel free to make changes on this PR or otherwise.
Thank you!