Skip to content

Conversation

@takologi
Copy link

@takologi takologi commented Jan 3, 2026

The project failed to compile with modern build tools due to macro conflicts and duplicate definitions. Specifically, lowercase min/max macros clashed with the standard library’s std::min/std::max, and ROTR was defined in multiple files under the same name. This caused ambiguous references and build errors.

Summary of Changes:

  • Renamed lowercase min/max macros to uppercase to avoid conflicts with std::min/std::max.
  • Renamed ROTR macro definitions to different names (ROTR_32, ROTR_SIZEOF), thus eliminating duplicates.

This change restores buildability and reliability for developers using up-to-date build tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant