cleaning up tests #253
Merged
cleaning up tests #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reorganizes the test suite to better mirror the jabs package structure, migrating tests from unittest to pytest and cleaning up outdated or broken tests. The changes improve test maintainability and remove deprecated test files.
Key changes:
- Migrated tests from unittest to pytest framework with modern fixtures and assertions
- Reorganized test directory structure to match jabs package layout
- Removed broken tests and test files referencing non-existent data
Reviewed changes
Copilot reviewed 34 out of 46 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_social_features/test_signal_processing.py | Removed skipped signal processing tests |
| tests/test_pose_file.py | Removed old unittest-based pose file tests |
| tests/test_pose_ancillary.py | Removed ancillary h5/gzip testing utilities |
| tests/test_base_features/test_segmentation.py | Removed broken segmentation tests |
| tests/project/test_video_manager.py | Updated to use uncompressed pose files instead of gzipped |
| tests/project/test_project.py | Updated to copy pose files directly without decompression |
| tests/project/init.py | Removed module docstring |
| tests/pose_estimation/test_pose_file.py | Added new pytest-based pose file tests with fixtures |
| tests/feature_tests/test_moments.py | Removed old unittest moments tests |
| tests/feature_tests/test_hu_moments.py | Removed old unittest hu moments tests |
| tests/feature_tests/seg_test_utils.py | Removed segmentation test utilities |
| tests/feature_modules/test_lixit_distance.py | Removed skipped lixit distance tests |
| tests/feature_modules/test_food_hopper.py | Removed old unittest food hopper tests |
| tests/feature_modules/test_corner_features.py | Removed old unittest corner feature tests |
| tests/feature_modules/base.py | Removed base test class for feature modules |
| tests/feature_modules/init.py | Removed module docstring |
| tests/feature_extraction/segmentation_features/test_segmentation.py | Added new pytest-based segmentation tests |
| tests/feature_extraction/segmentation_features/test_moments.py | Added new pytest-based moments tests |
| tests/feature_extraction/segmentation_features/test_hu_moments.py | Added new pytest-based hu moments tests |
| tests/feature_extraction/segmentation_features/conftest.py | Added shared fixtures for segmentation tests |
| tests/feature_extraction/landmark_features/test_lixit_distance.py | Added new pytest-based lixit distance tests |
| tests/feature_extraction/landmark_features/test_food_hopper.py | Added new pytest-based food hopper tests |
| tests/feature_extraction/landmark_features/test_corner_features.py | Added new pytest-based corner feature tests |
| tests/feature_extraction/landmark_features/conftest.py | Added shared fixtures for landmark feature tests |
| tests/feature_extraction/base_features/test_point_velocity_dirs.py | Added new tests for point velocity directions |
| tests/feature_extraction/base_features/test_point_speeds.py | Added new tests for point speeds |
| tests/feature_extraction/base_features/test_pairwise_distances.py | Added new tests for pairwise distances |
| tests/feature_extraction/base_features/test_centroid_velocity.py | Added new tests for centroid velocity |
| tests/feature_extraction/base_features/test_base_group.py | Added new tests for base feature group |
| tests/feature_extraction/base_features/test_angular_velocity.py | Added new tests for angular velocity |
| tests/feature_extraction/base_features/test_angles.py | Added new tests for angles |
| tests/feature_extraction/base_features/conftest.py | Added shared fixtures for base feature tests |
| tests/classifier/test_classifier.py | Added comprehensive classifier tests |
| tests/init.py | Removed module docstring |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/feature_extraction/segmentation_features/test_segmentation.py
Outdated
Show resolved
Hide resolved
tests/feature_extraction/base_features/test_pairwise_distances.py
Outdated
Show resolved
Hide resolved
tests/feature_extraction/base_features/test_angular_velocity.py
Outdated
Show resolved
Hide resolved
…on.py Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 34 out of 46 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ng GUI librarires on headless node)
keithshep
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reorganize tests/ directory to better mirror the jabs package layout
fixed some broken and skipped tests, removed others that were not relevant
added some new tests
used Claude Code to migrate older tests from unittest to pytest