add CatBoost tests, add missing ClassifierType enum value #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for CatBoost as a classifier option and includes comprehensive test coverage for the new classifier type. The changes ensure CatBoost is properly integrated into the existing classifier framework alongside Random Forest and XGBoost.
Key changes:
- Added
CATBOOSTenum value toClassifierType - Added comprehensive test suite covering CatBoost initialization, training, prediction, and NaN handling
- Minor comment corrections in the classifier implementation
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/jabs/types/classifier_types.py | Added CATBOOST enum value to ClassifierType |
| tests/classifier/test_classifier.py | Added comprehensive test coverage for CatBoost classifier functionality |
| src/jabs/classifier/classifier.py | Minor comment corrections (grammar fixes) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.