Patch interpolation_size argument bug #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergsalex
requested review from
C-1337ka,
SkepticRaven,
dahhei,
gbeane,
keithshep and
michberger
SkepticRaven
approved these changes
Aug 26, 2025
Contributor
SkepticRaven
left a comment
SkepticRaven
left a comment
There was a problem hiding this comment.
Just leaving the clarifying comment: We don't currently scan "interpolation" values for ground truth.
keithshep
approved these changes
Aug 26, 2025
michberger
approved these changes
Aug 26, 2025
gbeane
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the unused
--interpolation-sizeargument from theevaluate-ground-truthcommand.This argument was incorrectly being passed to the
evaluate_ground_truthfunction incompare_gt, which does not have that keyword argument.The argument does not appear to have been in use prior to our CLI refactor, and so we are removing it entirely.