Coerce frame interval columns to int before exploding #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergsalex
requested review from
SkepticRaven,
gbeane,
keithshep,
michberger and
ptuan5
gbeane
approved these changes
Dec 6, 2025
michberger
approved these changes
Dec 6, 2025
ptuan5
approved these changes
Dec 8, 2025
| # Ensure integer frame boundaries so range() receives ints even if upstream data was cast to float | ||
| for col in ["animal_idx", "start", "duration"]: | ||
| if col in expanded.columns: | ||
| expanded[col] = pd.to_numeric(expanded[col], errors="coerce").fillna(0).astype(int) |
Contributor
There was a problem hiding this comment.
Are "animal_idx" always integers? I think that is the case with all the system that we have, but just want to make sure.
keithshep
approved these changes
Dec 9, 2025
Comment on lines
+503
to
+504
| if col in expanded.columns: | ||
| expanded[col] = pd.to_numeric(expanded[col], errors="coerce").fillna(0).astype(int) |
There was a problem hiding this comment.
Just wondering about the consequence of turning errors into 0: should it instead be considered a fatal error and trigger a fail-fast exception? Approving and leaving final call to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for report from @michberger :
When GT annotations are missing, we synthesize “not-behavior” bouts covering the whole video. Concatenating those dummy rows onto an empty GT table makes pandas upcast numeric fields to float. Later,
_expand_intervals_to_framespassed those floats torange, raisingTypeError: 'float' object cannot be interpreted as an integer. The failure happened before any metrics/plots were produced.