-
Notifications
You must be signed in to change notification settings - Fork 0
Update singularity image locations for sumner2 #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
michberger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question...why are there multiple latest.sif in each of the images? Some are in a folder called "latest" and some inside a version folder. There is probably a logical reason but it strikes me as redundant files.
| container = "/projects/kumar-lab/meta/images/mouse-tracking-runtime/RBase/v0.1.2/latest.sif" | ||
| } | ||
| withLabel: "gait" { | ||
| container = "/projects/kumar-lab/multimouse-pipeline/nextflow-containers/gait-pipeline-2025-03-27.sif" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gait is a difficult one to version right now. It has unrelated histories between private (bitbucket) and public (github, cited paper version). I think the differences are just in Gautam's analysis and vms.
It looks like the paper version is v1.0.0.
The runtime currently there should probably be v1.1.0.
| container = "/projects/kumar-lab/multimouse-pipeline/nextflow-containers/gait-pipeline-2025-03-27.sif" | ||
| } | ||
| withLabel: "frailty" { | ||
| container = "/projects/kumar-lab/multimouse-pipeline/nextflow-containers/vfi-2025-03-27.sif" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VFI paper version was v1.
There should probably be a new release based on the history. Recommend v1.0.1 (all look like bugpatches).
| container = "/projects/kumar-lab/multimouse-pipeline/nextflow-containers/sleap-io-0.2.0.sif" | ||
| container = "/projects/kumar-lab/meta/images/mouse-tracking-runtime/sleap-io-0.2.0/v0.1.2/latest.sif" | ||
| } | ||
| withLabel: "rclone" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rclone container is a trivial container definition. I only add bash to the container so that nextflow logging can run. The version it's running happens to be rclone v1.70.3 (according to the tool itself).
I can add the definition file to the vm folder in this PR if you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added vm/rclone.def
Feel free to be more specific about its version, but I don't think it matters much.
All of the For example:
We should probably have a lab wide presentation on the new image and classifier directory structures. |
|
I'm going to merge as is for now so that @michberger can use the updated images. I'll make a new PR once we have final paths for the remaining images. |
This PR updates the singularity image locations to reference the new meta/images image repository.
Before we merge this, I would like to check with @SkepticRaven about the
gaitfrailtyandrcloneimages.