First draft of classifier generation pipeline #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergsalex
requested review from
C-1337ka,
SkepticRaven,
gbeane,
jacobbeierle and
keithshep
…s-classifier-artifact-generation
…s-classifier-artifact-generation
C-1337ka
approved these changes
Oct 7, 2025
SkepticRaven
approved these changes
Oct 7, 2025
Contributor
There was a problem hiding this comment.
Do we want configs outside the configs folder?
| "stitch_value": 5, | ||
| "filter_value": 5, | ||
| ], | ||
| // "Leg_splaying": [ // Currently can't be exported successfully |
Contributor
There was a problem hiding this comment.
JABS v0.34 + should have this fixed. I was able to build that artifact for #75. This classifier should be okay to uncomment and include.
| script: | ||
| def project_path = "${params.classifier_project_folders}/${project_folder_name}" | ||
| """ | ||
| jabs-init "${project_path}" ${window_sizes} -p 16 |
Contributor
There was a problem hiding this comment.
Does this write into the frozen project folder? This may cause conflicts in 2 situations:
- no write permission (maybe we want it this way, because it'll fail later when trying to publish results)
- 2 builds running at the same time will compete writing feature files to the same location
| "filter_value": 3*30, | ||
| 'grooming': [ | ||
| classifier_path: '/projects/kumar-lab/data/jabs/classifiers/v0.37.0/grooming/12199145d31213f79e23669d211cfa2fd33cedb9f11197b44f90a4b71297b6d2.pickle', | ||
| stitch_value: 300, |
Contributor
There was a problem hiding this comment.
😢 I like the multiplication to see 10s and 3s more clearly.
Contributor
There was a problem hiding this comment.
These look like patches for something not working. These should have been in a different PR to fix the main modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new workflow that automates the generation of classifier artifacts for the main workflow.
This will allow us to easily regenerate classifiers existing for new versions of JABs, as well as add new classifiers by placing their project directory into the
/projects/kumar-lab/projectsdirectory and updating theclassifier_source.configfile.There are still some tasks left to-do before this PR is ready to merge:
jabs-initstep to allow the classifiers to be generated in paralleljabs-initstep/projects/kumar-lab/data/and/projects/kumar-lab/projectsdirectories for use with this workflowReview of the current state would be appreciated given acknowledgement of the above.