Merged
Conversation
… for adding backround - shapes for icons;
… for adding backround colors - Zwischenstand;
…r_icons' into new-ui
jan-eichhorn
requested changes
May 7, 2025
Contributor
jan-eichhorn
left a comment
jan-eichhorn
left a comment
There was a problem hiding this comment.
Lass uns kurz darüber sprechen :) Sehr viel geschafft. Mega changes!
Contributor
There was a problem hiding this comment.
Würde ich auch erstmal so akzeptieren. Allerdings sollten wir im Nachgang nochmal recherchieren, ob es keine Alternative gibt. Wir hängen hier 7370 Zeilen an. Wenn das aber nötig ist, dann ist es so. Cool, dass Du erstmal eine Lösung gefunden hast, damit IntelliJ die Elemente kennt.
…bute to sl-icons and menu-items which do store the hex value of its color;
jan-eichhorn
requested changes
May 9, 2025
jan-eichhorn
approved these changes
May 9, 2025
# Conflicts: # src/taskpane/iconDownloadUtils.ts # src/taskpane/taskpane.ts
jan-eichhorn
had a problem deploying
to
github-pages
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
complete redesign of the UI: