fix: resolve cursor environment execution issues on Windows and improve cross-platform PATH handling#409
Open
codebysana wants to merge 1 commit into
Conversation
…ve PATH handling Signed-off-by: codebysana <sana.younas0530@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes failures in the Cursor adapter environment tests on Windows by improving how the fake agent command is executed and ensuring proper cross-platform command resolution.
It also resolves inconsistencies in environment variable handling for PATH vs Path, which was causing command execution to fail in some environments.
After these changes, all related adapter environment tests are now passing successfully on both Windows and non-Windows systems.
Changes
1. Fix fake agent command execution on Windows
Updated writeFakeAgentCommand to properly support Windows execution using a .cmd shim.
This ensures consistent behavior across platforms when spawning the fake agent.
2. Improve cross-platform PATH resolution
Updated server-utils.ts to correctly resolve executable paths across environments:
3. Stabilize test execution environment
These changes ensure:
Testing
All tests now pass successfully:
pnpm test cursor-local-adapter-environmentVerified on:
Result