Skip to content

fix novelupdates #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

fix novelupdates #1208

wants to merge 15 commits into from

Conversation

nguyd1
Copy link

@nguyd1 nguyd1 commented Oct 2, 2024

admin-ajax method is broken and keeps giving incorrect and duplicate and missing urls

new method will use page html from logged in user instead to give the correct urls

test on device with repo: https://raw.githubusercontent.com/nguyd1/lnreader-plugins/plugins/v3.0.0/.dist/plugins.min.json

tested novels with pages up to 15 and works fine, not sure about larger pages, for me a few weeks ago until now the issue was occurring on all the novels on novelupdates where the urls were duplicated, missing, redirected to the wrong url, or all of the above

we can add this method instead to fix the above issues, or create another novelupdates plugin to address the current issues since it looks like it has been ongoing since 2/2024 with no resolution, currently the plugin is unusable

@Batorian
Copy link
Contributor

Batorian commented Oct 3, 2024

Have you considered that NU is adding chapters to the pages reversed? So every time a chapter is added to a novel, you'll need to update all pages. That's the main reason why we still use admin-ajax + the long fetch times.

@nguyd1
Copy link
Author

nguyd1 commented Oct 3, 2024

Have you considered that NU is adding chapters to the pages reversed? So every time a chapter is added to a novel, you'll need to update all pages. That's the main reason why we still use admin-ajax + the long fetch times.

hey, not sure what u mean exactly by pages, are u referring to the pages on the novelupdates website? i was testing with fresh novels (deleted cache so first time fetching all chapters) and i was still getting the wrong chapters, looked at the data i was getting from ajax and i was receiving duplicate chapter urls pointing to chapters from different novels

@lalalasupa0
Copy link

#1480 Related it seems, I tested your plugin right quick but nuh huh

Screenshot_2025-02-13_090741_com rajarsheechatterjee LNReader
Screenshot_2025-02-13_090248_com rajarsheechatterjee LNReader
Screenshot_2025-02-13_090344_com rajarsheechatterjee LNReader
Screenshot_2025-02-13_090400_com rajarsheechatterjee LNReader

@lalalasupa0
Copy link

Actually, the NU website itself has had issues with bad linking within the TOCs recently, so maybe this is all related to it ?
For reference: https://www.novelupdatesforum.com/posts/7885250/

@Batorian
Copy link
Contributor

Batorian commented Mar 1, 2025

I propose closing this PR as implementing pages to NU is not a good solution. It was an approach I considered at first but considering a single page only holds 15 chapters it would lead to massive issues during library updates with big novels, as you would send a request to the NU server every time a new page gets loaded. I am still trying for solutions to avoid the chapter duplication issue but introducing paging is sadly not a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants