Skip to content

add feedback to remember for teaching in the future #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add feedback to remember for teaching in the future #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Day3/LombScargle2.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@
"source": [
"Problems:\n",
"\n",
"1. Ok, do we really need the Lomb-Scargle?\n",
"1. Ok, do we really need the Lomb-Scargle? NOTE for teaching this in the future: this question didn't get the intended point across very well. More scaffolding will be useful to add here in the future. A piece of feedback was to spend more time on the distinguishing features of LS and classical periodograms.\n",
"\n",
" a. Create some random observations of a sine curve. \n",
" b. Compute the classical periodogram (code this up yourself) and the Lomb-scargle periodogram (use astropy) for your dataset, and compare them. \n",
Expand Down