Skip to content

fixed issue1242. Allow p_of_k_a=None in angular_cl #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

fixed issue1242. Allow p_of_k_a=None in angular_cl #1244

merged 1 commit into from
Apr 29, 2025

Conversation

carlosggarcia
Copy link
Contributor

Closes #1242

@carlosggarcia carlosggarcia requested a review from damonge April 29, 2025 12:51
damonge
damonge approved these changes Apr 29, 2025
View reviewed changes
Copy link
Collaborator

@damonge damonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merge if tests pass.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 14731704007

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 97.459%
Totals Coverage Status
Change from base Build 14731589450: 0.001%
Covered Lines: 6559
Relevant Lines: 6730
💛 - Coveralls

@carlosggarcia carlosggarcia merged commit 798537e into master Apr 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damonge damonge damonge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

angular_cl does not accept p_of_k_a None
3 participants
@carlosggarcia @coveralls @damonge