-
Notifications
You must be signed in to change notification settings - Fork 6
Fix install #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix install #2
Changes from all commits
a4574c0
cc5469a
9c4212f
5816eae
7ada871
2893936
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,17 +13,48 @@ SCI is a program to identify sub-compartments from HiC data. SCI utilizes graph | |
| * python 2.7 | ||
|
|
||
| **Python Libraries** | ||
| * [scikit-learn] >=0.19.0 | ||
| * [scikit-learn] >=0.19.0, <= 0.20 | ||
| * [Numpy] >= 1.15 | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you update it to: [Numpy] <= 1.16 |
||
| * [tqdm]>=4.24 | ||
|
|
||
| `Scikit-learn 0.20 was the last version to support Python 2.7 and Python 3.4. Scikit-learn now requires Python 3.5 or newer.` | ||
|
|
||
| **C++ libraries** | ||
| * [GSL] | ||
|
|
||
| ### using Conda | ||
|
|
||
| use conda-forge channel | ||
|
|
||
| ```sh | ||
| conda config --add channels conda-forge | ||
|
|
||
| # | ||
| conda create -n sci_env python=2.7 | ||
|
|
||
| # once created | ||
| conda activate sci_env | ||
|
|
||
| # install own compilers | ||
| conda install compilers | ||
|
|
||
| # install GSL | ||
| conda install gsl | ||
|
|
||
| # save your env | ||
| mkdir -p envs | ||
| conda env export >envs/sci_env.yml | ||
|
|
||
| ``` | ||
|
|
||
| ## Installation | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I forgot to tell I updated the setup.py file to set 2 variables INCPATH and LIBPATH respectively to the include and lib path to gsl. And the user should edit them to make it work.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you plz update the README and add these instructions so people are aware of this mandatory step |
||
|
|
||
| ```sh | ||
| $ python setup.py | ||
| $ python setup.py install | ||
|
|
||
| # clean | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I should have mentioned this clean command is only after successful package install and optional
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you edit the README and add this comment plz |
||
| $ python setup.py clean | ||
|
|
||
| ``` | ||
| ## Input format | ||
|
|
||
|
|
@@ -76,6 +107,9 @@ SCI output sub-compartments annotation into BED format with the following fields | |
|
|
||
|
|
||
| ## Test run | ||
|
|
||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well I was not able to run this test because of the missing input data.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The input data link has been added in the readme section. Could you please double check? |
||
| `IS MISSING` | ||
|
|
||
| To preform test run for SCI please follow the following steps: | ||
| 1. Go the Input_sample directory | ||
| ```sh | ||
|
|
@@ -99,4 +133,4 @@ $ python sci.py -n test -f Input_sample/SCI_input.txt -r 100000 -g chromosome_si | |
| [scikit-learn]: http://scikit-learn.org/stable/ | ||
| [Numpy]: http://www.numpy.org/ | ||
| [tqdm]: https://pypi.org/project/tqdm/ | ||
| [GSL]: http://www.gnu.org/software/gsl/ | ||
| [GSL]: http://www.gnu.org/software/gsl/ | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Scikit-learn 0.20 was the last version to support Python 2.7 and Python 3.4. Scikit-learn now requires Python 3.5 or newer. | ||
| #scikit-learn >= 0.18 | ||
| scikit-learn > 0.18, < 0.21 | ||
| # last numpy release tosupport Python 2.7: see https://docs.scipy.org/doc/numpy/release.html#numpy-1-16-0-release-notes | ||
| Numpy <=1.16.0 | ||
| # The last SciPy version to do so is SciPy 1.2.x: https://www.scipy.org/scipylib/faq.html#do-numpy-and-scipytill-support-python-2-7 | ||
| scipy <=1.2 | ||
| tqdm |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,16 +8,26 @@ | |
| VERSION = '0.1.0' | ||
|
|
||
|
|
||
| CONDA_PATH = os.getenv("CONDA_PREFIX") | ||
| INCPATH = os.path.join(CONDA_PATH,"include") | ||
| LIBPATH=os.path.join(CONDA_PATH,"lib") | ||
|
|
||
|
|
||
| LIBS="-lgsl -lgslcblas -lpthread -L{}".format(LIBPATH) | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should add a comment to tell people to edit these 2 variables INCPATH and LIBPATH to point to their include and lib path to gsl
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you plz add such a comment above these 2 variables
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And maybe replace my paths by some placeholder strings
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jos4uke I am trying to push some changes to the branch. May you give me permission to do so?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes for sure |
||
|
|
||
| def compile_line(): | ||
| compile_command = ("g++ LINE/line.cpp -o LINE/line" | ||
| "-lgsl -lgslcblas -lpthread") | ||
| compile_command = ("g++ LINE/line.cpp -I{} -o LINE/line {}".format(INCPATH,LIBS)) | ||
| return_code = call(compile_command.split()) | ||
| if return_code != 0: | ||
| sys.exit(("LINE compilation has failed." | ||
| "Please make sure to install GSL library")) | ||
|
|
||
| compile_line() | ||
|
|
||
| ## Important notes to requirements: | ||
| # 1. Last numpy release tosupport Python 2.7: see https://docs.scipy.org/doc/numpy/release.html#numpy-1-16-0-release-notes | ||
| # 2. The last SciPy version to do so is SciPy 1.2.x: https://www.scipy.org/scipylib/faq.html#do-numpy-and-scipytill-support-python-2-7 | ||
| # 3. Scikit-learn 0.20 was the last version to support Python 2.7 and Python 3.4. Scikit-learn now requires Python 3.5 or newer. | ||
| setup( | ||
|
|
||
| name="sci", | ||
|
|
@@ -26,8 +36,9 @@ def compile_line(): | |
| author_email='[email protected]', | ||
| packages=find_packages(), | ||
| install_requires=[ | ||
| 'numpy', | ||
| 'scikit-learn', | ||
| 'numpy<=1.16.0', | ||
| 'scipy<=1.2', | ||
| 'scikit-learn>=0.19,<=0.20', | ||
| 'tqdm' | ||
| ], | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot to update the dependency version on numpy, the last numpy release to support Python 2.7: see https://docs.scipy.org/doc/numpy/release.html#numpy-1-16-0-release-notes
should be: [Numpy] <= 1.16