feat: Add contract deployment script for testnet and mainnet#428
Conversation
1df3653 to
9f93054
Compare
|
Bro i have been solving this CI since 11pm - 2:19am |
|
hey, main was failing CI from broken auth imports + frontend parse errors. fixed and pushed to main now. please rebase to pick up the fixes: git fetch upstream
git rebase upstream/main
git push --force-with-leaseif there's a conflict, resolve it locally and we'll review once CI is green. |
|
pls merge my oga 😏 |
|
hey, since main now has #444 merged (the cancel stream endpoint), your branch is showing stale modifications to please rebase again to drop those: git fetch upstream
git rebase upstream/main
# during rebase, when conflicts appear in cancel.ts or sorobanService.ts:
git checkout upstream/main -- backend/src/controllers/stream/cancel.ts backend/src/services/sorobanService.ts
git add backend/src/controllers/stream/cancel.ts backend/src/services/sorobanService.ts
git rebase --continue
git push --force-with-leaseafter that, your diff should only show the actual feature for this PR and we can merge. |
b72cbec to
96a83a4
Compare
|
My feature branch is correctly rebased on upstream/main and only contains the contract deployment script. The CI failures are due to TypeScript build errors in upstream/main from PR #444. The cancel.ts and sorobanService.ts files need to be fixed on upstream/main before any branch can pass CI. |
|
hey @jotel-dev, you were right that the CI failure was unrelated to your branch — main had real TypeScript errors in cancel.ts and sorobanService.ts. fixed and pushed. rebase on latest main and CI should pass. |
|
hey, main CI is fully green now. there were several real TypeScript and test issues from #444's merge that have all been fixed. please rebase one more time: git fetch upstream
git rebase upstream/main
git push --force-with-leaseyour PR's diff should be much cleaner after this rebase since main now has the canonical versions of cancel.ts, sorobanService.ts, and the withdraw test. |
- Update scripts/deploy.sh with environment variable validation - Support --network testnet|mainnet flag - Validate required env vars (DEPLOYER_SECRET, ADMIN_ADDRESS, TREASURY_ADDRESS, FEE_RATE_BPS) - Save contract ID and tx hashes to deployment-info.json - Remove *.sh from .gitignore to allow deployment scripts - Update README with deployment documentation
96a83a4 to
af29b0d
Compare
|
Done ✅ @ogazboiz |
ogazboiz
left a comment
There was a problem hiding this comment.
hey @jotel-dev, clean PR now. the deploy.sh is comprehensive — env validation, build, WASM optimization, deploy, initialize, deployment-info.json tracking. the .gitignore fix to allow shell scripts is correct. all CI green. merging!
if you want to keep contributing or follow up on open issues, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0
closes #374
Description
Type of Change
Related Issues
Closes #
Changes Made
Testing
Test Coverage
Test Steps
Breaking Changes
Breaking Changes:
Migration Guide:
Screenshots/Demo
Checklist
Additional Notes