Skip to content

feat: Add contract deployment script for testnet and mainnet#428

Merged
ogazboiz merged 1 commit into
LabsCrypt:mainfrom
jotel-dev:feat/contract-deployment-script-testnet-mainnet
May 1, 2026
Merged

feat: Add contract deployment script for testnet and mainnet#428
ogazboiz merged 1 commit into
LabsCrypt:mainfrom
jotel-dev:feat/contract-deployment-script-testnet-mainnet

Conversation

@jotel-dev
Copy link
Copy Markdown
Contributor

@jotel-dev jotel-dev commented Apr 28, 2026

closes #374

  • Update scripts/deploy.sh with environment variable validation
  • Support --network testnet|mainnet flag
  • Validate required env vars (DEPLOYER_SECRET, ADMIN_ADDRESS, TREASURY_ADDRESS, FEE_RATE_BPS)
  • Save contract ID and tx hashes to deployment-info.json
  • Remove *.sh from .gitignore to allow deployment scripts
  • Update README with deployment documentation

Description

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔧 Refactoring (no functional changes)
  • ⚡ Performance improvement
  • 🧪 Test addition or update

Related Issues

Closes #

Changes Made

Testing

Test Coverage

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed

Test Steps

Breaking Changes

Breaking Changes:

Migration Guide:

Screenshots/Demo

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have checked for breaking changes and documented them if applicable

Additional Notes

@jotel-dev jotel-dev force-pushed the feat/contract-deployment-script-testnet-mainnet branch 2 times, most recently from 1df3653 to 9f93054 Compare April 29, 2026 00:48
@jotel-dev
Copy link
Copy Markdown
Contributor Author

jotel-dev commented Apr 29, 2026

Bro i have been solving this CI since 11pm - 2:19am
like it seem the issue is not from my side
pls review and merge

@ogazboiz
Copy link
Copy Markdown
Contributor

hey, main was failing CI from broken auth imports + frontend parse errors. fixed and pushed to main now. please rebase to pick up the fixes:

git fetch upstream
git rebase upstream/main
git push --force-with-lease

if there's a conflict, resolve it locally and we'll review once CI is green.

@jotel-dev
Copy link
Copy Markdown
Contributor Author

pls merge my oga 😏
@ogazboiz

@ogazboiz
Copy link
Copy Markdown
Contributor

hey, since main now has #444 merged (the cancel stream endpoint), your branch is showing stale modifications to backend/src/controllers/stream/cancel.ts and backend/src/services/sorobanService.ts that overlap with main's current state.

please rebase again to drop those:

git fetch upstream
git rebase upstream/main
# during rebase, when conflicts appear in cancel.ts or sorobanService.ts:
git checkout upstream/main -- backend/src/controllers/stream/cancel.ts backend/src/services/sorobanService.ts
git add backend/src/controllers/stream/cancel.ts backend/src/services/sorobanService.ts
git rebase --continue
git push --force-with-lease

after that, your diff should only show the actual feature for this PR and we can merge.

@jotel-dev jotel-dev force-pushed the feat/contract-deployment-script-testnet-mainnet branch 4 times, most recently from b72cbec to 96a83a4 Compare May 1, 2026 09:57
@jotel-dev
Copy link
Copy Markdown
Contributor Author

My feature branch is correctly rebased on upstream/main and only contains the contract deployment script. The CI failures are due to TypeScript build errors in upstream/main from PR #444. The cancel.ts and sorobanService.ts files need to be fixed on upstream/main before any branch can pass CI.

@ogazboiz
Copy link
Copy Markdown
Contributor

ogazboiz commented May 1, 2026

hey @jotel-dev, you were right that the CI failure was unrelated to your branch — main had real TypeScript errors in cancel.ts and sorobanService.ts. fixed and pushed. rebase on latest main and CI should pass.

@ogazboiz
Copy link
Copy Markdown
Contributor

ogazboiz commented May 1, 2026

hey, main CI is fully green now. there were several real TypeScript and test issues from #444's merge that have all been fixed. please rebase one more time:

git fetch upstream
git rebase upstream/main
git push --force-with-lease

your PR's diff should be much cleaner after this rebase since main now has the canonical versions of cancel.ts, sorobanService.ts, and the withdraw test.

- Update scripts/deploy.sh with environment variable validation
- Support --network testnet|mainnet flag
- Validate required env vars (DEPLOYER_SECRET, ADMIN_ADDRESS, TREASURY_ADDRESS, FEE_RATE_BPS)
- Save contract ID and tx hashes to deployment-info.json
- Remove *.sh from .gitignore to allow deployment scripts
- Update README with deployment documentation
@jotel-dev jotel-dev force-pushed the feat/contract-deployment-script-testnet-mainnet branch from 96a83a4 to af29b0d Compare May 1, 2026 17:58
@jotel-dev
Copy link
Copy Markdown
Contributor Author

Done ✅ @ogazboiz

Copy link
Copy Markdown
Contributor

@ogazboiz ogazboiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jotel-dev, clean PR now. the deploy.sh is comprehensive — env validation, build, WASM optimization, deploy, initialize, deployment-info.json tracking. the .gitignore fix to allow shell scripts is correct. all CI green. merging!

if you want to keep contributing or follow up on open issues, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0

@ogazboiz ogazboiz merged commit a03e7a3 into LabsCrypt:main May 1, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add contract deployment script for testnet and mainnet

2 participants