feat(loan_manager): add repayment below minimum error handling and up…#37
Merged
Conversation
ogazboiz
approved these changes
Jun 20, 2026
ogazboiz
left a comment
Contributor
There was a problem hiding this comment.
verified locally last round (fmt+clippy+240 tests green) and ci is now green against the post-#36 base. clean conversion of the below-minimum repay panic and the withdrawal-cooldown panic into typed errors (RepaymentBelowMinimum, WithdrawalCooldownActive), with the should_panic tests switched to try_/assert_eq!(Err(...)). merging.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8
✅ Requested error handling updates are in place
I updated the contracts so the user-facing cases now return typed errors instead of panicking:
repaynow returnsLoanError::RepaymentBelowMinimumfor partial repayments that fall below the configured floor.set_min_repayment_amountnow returnsLoanError::InvalidAmountfor negative input instead of panicking.adjust_total_outstandingis still a panic, but it is now documented as an internal invariant that should be unreachable from normal inputs.PoolError::WithdrawalCooldownActiveinstead of panicking.