Update lending pool fuzz target for LP-share model#41
Conversation
ogazboiz
left a comment
There was a problem hiding this comment.
thanks for updating the fuzz target, but this can't merge as-is, it would destructively revert main. two hard blockers plus fmt:
-
silent clobber. this branch is 21 commits behind main and carries an OLDER lending_pool/src/lib.rs that DELETES the managed-assets model now on main: it removes TotalManagedAssets, record_yield, set_loan_manager/get_loan_manager, get_total_managed_assets, WithdrawalCooldownActive, reverts CURRENT_VERSION 4->3, and reverts share pricing from total_managed_assets back to raw read_pool_balance. merging would silently wipe that with no conflict marker. please rebase: git fetch origin && git rebase origin/main (drop the stale lending_pool changes so the diff is fuzz-only), then re-run CI.
-
it also bundles an older copy of your #39 remittance_nft consolidation (commit 0a46b75), which both duplicates #39 and re-introduces the trailing-whitespace fmt issues #39 already fixed. after rebasing, drop the remittance_nft commit and keep #41 fuzz-only, #39 is the canonical version of that change.
-
fmt fails: lending_pool/src/test.rs:1520,1541,1548,1560,1573 and remittance_nft/src/lib.rs:608 + test.rs:1901. run cargo fmt --all from the repo root.
one semantic note for after the rebase: the fuzz invariant assert_no_value_creation uses raw token pool_balance as the redeemable basis, but on main share value derives from TotalManagedAssets, so the invariant may be stale against the current model, worth a look once it's rebased.
rebase to fuzz-only + fmt and i'll re-review.
if you want to keep contributing, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0
Changes Made
Closes #21