CI: Add Nightly arm64 Linux job, and nightly distribution jobs #3321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
ADKaster
force-pushed
the
arm64-and-distro-nightly
branch
from
3b5e8ec to
58b8819
Compare
ADKaster
force-pushed
the
arm64-and-distro-nightly
branch
from
58b8819 to
8ad14d5
Compare
ADKaster
commented
Feb 17, 2025
ADKaster
force-pushed
the
arm64-and-distro-nightly
branch
2 times, most recently
from
80b1b3a to
cac4395
Compare
ADKaster
force-pushed
the
arm64-and-distro-nightly
branch
from
cac4395 to
a825be0
Compare
|
Note that arm64 Linux builds disable wasm spec tests, due to WebAssembly/wabt#2533 |
|
@gmta where is the "required checks" config? This PR will rename "Lagom (Linux, ubuntu-24.04, NO_FUZZ, Clang, true) / CI" to "Lagom / (Linux, ubuntu-24.04, x86_64, Sanitizer_CI, Clang, true) / CI" |
Ah, found it in the Branch Protection rules for |
gmta
reviewed
Feb 19, 2025
This was a relic from the SerenityOS CI, where architecture meant what architecture to build Serenity for. For just ladybird, we might want to build ladybird for multiple architectures per OS.
This requires setting VCPKG_FORCE_SYSTEM_BINARIES to 1, per vcpkg documentation.
This avoids static builds putting the "no-op" implementation of PlaybackStream::create() in the static archive before the strong implementation later. On ELF (and probably PE/COFF too), a weak definition in a static archive is chosen and locked-in as the definition before a strong definition later in the archive. Before this change, static builds would have no audio support at all.
ADKaster
force-pushed
the
arm64-and-distro-nightly
branch
from
a825be0 to
e458296
Compare
gmta
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the Lagom CI template a bit:
Add a nightly job using the newly widely available ubuntu-24.04-arm runners (https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/)
Add 3 nightly jobs for Distribution_CI preset: macOS, x86_64 linux, arm64 linux.
Draft until the new jobs pass on my fork. Expected-to-pass run ™️ : https://github.com/ADKaster/ladybird-browser/actions/runs/13394961544